Skip to content

Conversation

@lgoltz
Copy link
Contributor

@lgoltz lgoltz commented Dec 15, 2025

Currently a GetFetureInfo requests based on FeatureLayer uses the first geometry column, to match the requested click point. This geometry may differ from the geometry used to render the GetMap request or may be empty,

This PR fixes this by using the same geometry property for GetFeatureInfo requests from the style as the GetMap request.

Fixes #1640.

@lgoltz lgoltz added this to the 3.6.6 milestone Dec 15, 2025
@lgoltz lgoltz added the WMS deegree Web Map Service label Dec 15, 2025
@julianzz98
Copy link
Contributor

The fix was successfully tested on a local environment!

@tfr42 tfr42 changed the title Fix empty GFI response on an FeatureType with multiple geometry columns Fixed empty GFI response on a FeatureType with multiple geometry columns Dec 22, 2025
@tfr42 tfr42 added needs discussion requires discussion with contributor under review PR under review by TMC member labels Jan 14, 2026
@tfr42
Copy link
Member

tfr42 commented Jan 14, 2026

@julianzz98 How does the GFI request/response changes when the tunable deegree.sqldialect.consider-all-geometry-columns is enabled or not?

@stephanr
Copy link
Member

We discussed this PR in yesterday's TMC meeting, and from the currently supplied information in this PR, the following questions arose:

  • It looks like this PR will change the behavior of deegree, which currently would be included in an incremental update that may or may not surprise users.
  • This PR shares similarities with Enhanced bbox requests without geometry property to consider all geometry properties (3.6) #1732 where, after discussions about the behavior change, it was changed to be opt-in via tunable. And visually it is unclear if and how both PR are related to each other.
  • Does the change in by including more geometry properties have a security implication by widening the scope for the query to the datastore?

To go into detail about the security implications here, as discussed in the TMC meeting, it is unclear if the additional filter will widen or narrow the feature requested from the feature store (are more features returned, or are only the same features returned and correctly selected for rendering)?.

With the current supplied information, this question could not be answered.

So in my understanding, a WMS GetFeatureInfo should request the same features as a WMS GetMap would do and then filter out the features requested by the GetFeatureInfo click position.

So one way to better understand the implications of this PR would be to document the SQL before and after applying this PR to see if there are security implications. (Maybe also with and without the tunable of #1732, if this changes the behavior.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs discussion requires discussion with contributor under review PR under review by TMC member WMS deegree Web Map Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetFeatureInfo on FeatureTypes with multiple geoemtry columns

4 participants