Skip to content

ci(tests): use new version of the coverage uploader#345

Merged
deepcharles merged 7 commits intomasterfrom
ci-test-upload-gha-version
Apr 28, 2025
Merged

ci(tests): use new version of the coverage uploader#345
deepcharles merged 7 commits intomasterfrom
ci-test-upload-gha-version

Conversation

@oboulant
Copy link
Copy Markdown
Collaborator

Use new version of the uploader gha since v2 is not supported anymore: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

It was falling the CI job "coverage", for instance see here for symptoms: https://github.com/deepcharles/ruptures/actions/runs/13174606396/job/36771046953

@github-actions github-actions Bot added the Type: CI Changes to CI configuration files and scripts label Apr 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (68ea247) to head (eb86db6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          40       40           
  Lines         980      980           
=======================================
  Hits          968      968           
  Misses         12       12           
Flag Coverage Δ
unittests 98.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oboulant
Copy link
Copy Markdown
Collaborator Author

Seems like the .pre-commit-hook.yaml from https://github.com/PyCQA/docformatter embarks this :

-   id: docformatter-venv
    name: docformatter-venv
    description: 'Formats docstrings to follow PEP 257. Uses python3 -m venv.'
    entry: docformatter
    args: [-i]
    language: python_venv
    types: [python]

Which is problematic and causing the error in https://results.pre-commit.ci/run/github/118264731/1744630519.m5ln0aogQsSHAPF3-j5JbQ

@oboulant
Copy link
Copy Markdown
Collaborator Author

Solution found here : PyCQA/docformatter#293 (comment)

@oboulant
Copy link
Copy Markdown
Collaborator Author

Follow up on: #345 (comment)

Even if in on master there is no docformatter-venv in https://github.com/PyCQA/docformatter/blob/master/.pre-commit-hooks.yaml

There is docformatter-venv in the tag v1.7.5 : https://github.com/PyCQA/docformatter/blob/v1.7.5/.pre-commit-hooks.yaml

This is the root cause of the problem for the pre-commit to fail.

@oboulant oboulant self-assigned this Apr 16, 2025
@oboulant oboulant requested a review from deepcharles April 18, 2025 08:07
@deepcharles deepcharles merged commit ae23aad into master Apr 28, 2025
17 of 18 checks passed
@deepcharles deepcharles deleted the ci-test-upload-gha-version branch April 28, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants