-
Notifications
You must be signed in to change notification settings - Fork 105
HAOC: Add log message when HAOC is enabled #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When HAOC is enabled via kernel command line, print an informational message to dmesg. This helps in verifying the feature status during boot.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds an informational kernel log message when HAOC is enabled via the kernel command line, emitted right before initializing the IEE mapping region, to make HAOC activation visible in dmesg during boot. Sequence diagram for HAOC-enabled mem_init loggingsequenceDiagram
participant Boot as BootProcess
participant Kernel as Kernel
participant Memory as mem_init
participant Logger as printk
participant IEE as iee_init
Boot->>Kernel: start_kernel
Kernel->>Memory: mem_init()
Memory->>Memory: check haoc_enabled
alt haoc_enabled is true
Memory->>Logger: pr_info(HAOC is enabled by kernel command line.)
Memory->>IEE: iee_init()
else haoc_enabled is false
Memory-->>IEE: iee_init() not called
end
Memory-->>Kernel: return
Kernel-->>Boot: continue boot sequence
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个git diff进行审查:
改进建议: if (haoc_enabled) {
pr_info("HAOC: Initializing Intel IEE (In-Memory Encryption Engine)\n");
iee_init();
}修改理由:
这样的修改既保持了原有功能,又提高了代码的可维护性和可观测性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opsiff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds informational logging to indicate when the HAOC (Hardware-Assisted Object Confinement) feature is enabled during x86_64 memory initialization. The log message helps system administrators and developers verify that HAOC has been successfully activated via the kernel command line parameter during boot.
Key Changes
- Added a
pr_info()call to log when HAOC is enabled, improving boot-time observability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| if (haoc_enabled) | ||
| if (haoc_enabled) { | ||
| pr_info("HAOC is enabled by kernel command line."); |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log message should be more concise and consistent with kernel logging conventions. Based on similar feature enablement messages in the codebase (e.g., "PV spinlocks enabled", "CET detected: Indirect Branch Tracking enabled", "Virtual NMI enabled"), consider simplifying this message to just "HAOC enabled" without mentioning "by kernel command line", as this is implied by the fact that the log appears during boot initialization.
| pr_info("HAOC is enabled by kernel command line."); | |
| pr_info("HAOC enabled"); |
When HAOC is enabled via kernel command line, print an informational message to dmesg. This helps in verifying the feature status during boot.
Summary by Sourcery
Enhancements: