-
Notifications
You must be signed in to change notification settings - Fork 105
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin_loongarch_desktop_defconfig: restore CONFIG_RTS5208 #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin_loongarch_desktop_defconfig: restore CONFIG_RTS5208 #1386
Conversation
deepin inclusion category: bugfix Fixes: f56f8cb ("deepin: config: remove R8712U") Signed-off-by: Wentao Guan <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestores RTS5208 card reader driver support in the Deepin LoongArch desktop kernel configuration by re-enabling the corresponding Kconfig option in the defconfig. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个配置文件的修改进行审查:
改进建议:
总体来说,这个修改是合理的,符合内核配置的最佳实践。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongert The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restores the CONFIG_RTS5208 kernel configuration option for the Deepin LoongArch desktop kernel that was inadvertently removed in a previous commit (f56f8cb) which removed R8712U driver support.
- Restores CONFIG_RTS5208=m to the deepin_loongarch_desktop_defconfig
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The time from PR submission to merge was less than a few seconds, which clearly shows there was no code review (even though only a single configuration line was changed) and no wait for CI build tests. This is wrong and non‑compliant. Clicking the Approve button is tied to a maintainer’s responsibility and rigor; skipping review only creates a mess and technical debt. Please do not bring the bad practices that occurred during UOS v20 maintenance into the deepin community. @dongert |
deepin inclusion
category: bugfix
Fixes: f56f8cb ("deepin: config: remove R8712U")
Summary by Sourcery
Bug Fixes: