[Deepin-Kernel-SIG] [linux 6.12-y] [Upstream] Merge HID/intel-thc-hid from mainline master

[Cryolitia]

No description provided.

[sourcery-ai]

Sorry @Cryolitia, your pull request is larger than the review limit of 150000 diff characters

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [opsiff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR merges Intel Touch Host Controller (THC) HID driver support from mainline to the Deepin 6.12-y kernel. The THC hardware provides SPI and I2C interfaces for touch devices with hardware-accelerated DMA capabilities. The changes introduce:

• Core THC hardware abstraction layer with register definitions and DMA support
• QuickSPI driver implementing HID-over-SPI protocol
• QuickI2C driver implementing HID-over-I2C protocol
• Protocol definition headers for HIDSPI and HIDI2C standards

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
include/linux/hid-over-spi.h	HIDSPI protocol structures and definitions
include/linux/hid-over-i2c.h	HIDI2C protocol structures and definitions
drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h	THC hardware register definitions and constants
drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.*	THC DMA engine implementation
drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.*	THC device initialization and operations
drivers/hid/intel-thc-hid/intel-quickspi/*	QuickSPI driver for HID-over-SPI devices
drivers/hid/intel-thc-hid/intel-quicki2c/*	QuickI2C driver for HID-over-I2C devices
drivers/hid/intel-thc-hid/Kconfig	Configuration options for THC drivers
drivers/hid/intel-thc-hid/Makefile	Build rules for THC drivers
drivers/hid/Kconfig	Integration of THC Kconfig
drivers/hid/Makefile	Integration of THC build
arch/x86/configs/deepin_x86_desktop_defconfig	Enable THC drivers as modules
MAINTAINERS	Add THC driver maintainers
Documentation/hid/index.rst	Add THC documentation reference

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[opsiff]

至少看到有缺失下面的补丁 需要再检查下
commit 8fe2cd8
Author: Even Xu [email protected]
Date: Fri Sep 19 15:09:39 2025 +0800

HID: intel-thc-hid: Intel-quickspi: switch first interrupt from level to edge detection

The original implementation used level detection for the first interrupt
after device reset to avoid potential interrupt line noise and missed
interrupts during the initialization phase. However, this approach
introduced unintended side effects when tested with certain touch panels,
including:
 - Delayed hardware interrupt response
 - Multiple spurious interrupt triggers

Switching back to edge detection for the first interrupt resolves these
issues while maintaining reliable interrupt handling.

Extensive testing across multiple platforms with touch panels from
various vendors confirms this change introduces no regressions.

[[email protected]: properly capitalize shortlog]
Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation")
Tested-by: Rui Zhang <[email protected]>
Signed-off-by: Even Xu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

[Cryolitia]

至少看到有缺失下面的补丁 需要再检查下 commit 8fe2cd8 Author: Even Xu [email protected] Date: Fri Sep 19 15:09:39 2025 +0800

HID: intel-thc-hid: Intel-quickspi: switch first interrupt from level to edge detection

The original implementation used level detection for the first interrupt
after device reset to avoid potential interrupt line noise and missed
interrupts during the initialization phase. However, this approach
introduced unintended side effects when tested with certain touch panels,
including:
 - Delayed hardware interrupt response
 - Multiple spurious interrupt triggers

Switching back to edge detection for the first interrupt resolves these
issues while maintaining reliable interrupt handling.

Extensive testing across multiple platforms with touch panels from
various vendors confirms this change introduces no regressions.

[[email protected]: properly capitalize shortlog]
Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation")
Tested-by: Rui Zhang <[email protected]>
Signed-off-by: Even Xu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

再看看

[deepin-ci-robot]

deepin pr auto review

我将对这个Intel THC (Touch Host Controller)驱动代码进行审查,重点关注语法逻辑、代码质量、性能和安全性等方面。

1. 语法和逻辑审查:

• 代码整体结构清晰,使用标准的Linux驱动框架
• 正确使用Linux内核API和锁机制
• DMA操作和内存管理符合内核规范
• 错误处理路径完整

2. 代码质量:

• 模块化设计良好,将THC核心、SPI和I2C功能分离
• 注释充分,特别是硬件寄存器定义
• 使用适当的抽象层封装硬件操作
• 遵循Linux内核编码风格

3. 性能考虑:

• 使用DMA减少CPU开销
• 实现了中断处理和轮询两种模式
• 合理的缓存对齐和内存分配策略
• 支持多种IO模式(Single/Dual/Quad)

4. 安全性:

• 正确的输入参数验证
• 适当的边界检查
• 安全的内存访问模式
• 中断和竞态条件的处理

主要改进建议:

1. 错误处理增强:

// 在thc_dma_write中增加更严格的参数检查
if (!buffer || buf_len <= 0 || buf_len > dev->dma_ctx->dma_config[THC_TXDMA].max_packet_size) {
    dev_err(dev->dev, "Invalid parameters: buffer %p, len %zu, max %zu\n",
            buffer, buf_len, dev->dma_ctx->dma_config[THC_TXDMA].max_packet_size);
    return -EINVAL;
}

2. 资源管理改进:

// 在thc_dma_allocate中增加资源清理
int thc_dma_allocate(struct thc_device *dev)
{
    int ret, chan;
    
    for (chan = 0; chan < MAX_THC_DMA_CHANNEL; chan++) {
        ret = setup_dma_buffers(dev, &dev->dma_ctx->dma_config[chan],
                            dev->dma_ctx->dma_config[chan].dir);
        if (ret) {
            // 清理已分配的资源
            while (chan--)
                release_dma_buffers(dev, &dev->dma_ctx->dma_config[chan]);
            return ret;
        }
    }
    return 0;
}

3. 性能优化建议:

// 在频繁访问的寄存器操作中使用缓存
static inline u32 thc_read_reg_cached(struct thc_device *dev, u32 offset)
{
    if (dev->reg_cache[offset] != INVALID_CACHE_VALUE)
        return dev->reg_cache[offset];
        
    dev->reg_cache[offset] = ioread32(dev->mmio_addr + offset);
    return dev->reg_cache[offset];
}

4. 安全性增强:

// 在PIO操作中增加超时和重试机制
int thc_tic_pio_read(struct thc_device *dev, const u32 address,
                     const u32 size, u32 *actual_size, u32 *buffer)
{
    int retries = 0;
    int ret;
    
    while (retries < MAX_RETRIES) {
        ret = prepare_pio(dev, opcode, address, size);
        if (ret)
            return ret;
            
        ret = pio_wait(dev);
        if (!ret)
            break;
            
        retries++;
        if (retries == MAX_RETRIES)
            return -ETIMEDOUT;
            
        msleep(PIO_RETRY_DELAY_MS);
    }
    
    return pio_complete(dev, buffer, actual_size);
}

5. 调试支持增强:

#ifdef CONFIG_DEBUG_FS
// 添加debugfs接口用于调试
static int thc_debug_show(struct seq_file *s, void *unused)
{
    struct thc_device *dev = s->private;
    
    seq_printf(s, "DMA Status:\n");
    seq_printf(s, "  RXDMA1: %s\n", 
               dma_is_enabled(&dev->dma_ctx->dma_config[THC_RXDMA1]) ? "enabled" : "disabled");
    // ... 其他状态信息
    
    return 0;
}
#endif

6. 电源管理优化:

// 在空闲时降低功耗
static void thc_enter_low_power(struct thc_device *dev)
{
    // 降低时钟频率
    thc_set_clock_freq(dev, THC_LOW_POWER_FREQ);
    
    // 关闭不必要的DMA通道
    thc_dma_channel_disable(dev, THC_TXDMA);
    
    // 进入低功耗LTR模式
    thc_change_ltr_mode(dev, THC_LTR_MODE_LP);
}

7. 可维护性改进:

// 使用宏简化寄存器操作
#define THC_REG_READ(dev, reg) \
    ioread32((dev)->mmio_addr + (reg##_OFFSET))
    
#define THC_REG_WRITE(dev, reg, val) \
    iowrite32((val), (dev)->mmio_addr + (reg##_OFFSET))
    
#define THC_REG_UPDATE(dev, reg, mask, val) \
    THC_REG_WRITE(dev, reg, (THC_REG_READ(dev, reg) & ~(mask)) | (val))

8. 测试相关改进:

#ifdef CONFIG_TEST_THC
// 添加测试模式支持
static int thc_self_test(struct thc_device *dev)
{
    int ret;
    
    // 测试DMA通道
    ret = thc_dma_test(dev);
    if (ret)
        return ret;
        
    // 测试PIO操作
    ret = thc_pio_test(dev);
    if (ret)
        return ret;
        
    // 测试中断处理
    ret = thc_interrupt_test(dev);
    if (ret)
        return ret;
        
    return 0;
}
#endif

这些改进建议主要针对:

1. 增强错误处理和恢复机制
2. 优化资源管理和内存使用
3. 提高代码可维护性和可测试性
4. 改进性能和电源管理
5. 增强调试和诊断功能

建议按优先级逐步实施这些改进,优先处理错误处理和安全性相关的问题。