Skip to content

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Jan 5, 2026

deepin inclusion
category: bugfix

Fix situation when dkms drm driver not install to light the monitor.

Link: #724

Summary by Sourcery

Bug Fixes:

  • Fix missing display output on ARM64 systems when DKMS DRM drivers are unavailable by re-enabling EFI framebuffer support in the kernel configuration.

deepin inclusion
category: bugfix

Fix situation when dkms drm driver not install to light the monitor.

Link: deepin-community#724
Signed-off-by: Wentao Guan <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Re-enables the FB_EFI framebuffer option in the Deepin ARM64 desktop defconfig so that displays work even when a DKMS-based DRM driver is not installed or loaded.

File-Level Changes

Change Details Files
Re-enable EFI framebuffer support in the Deepin ARM64 desktop defconfig.
  • Set the FB_EFI configuration option to enabled in the deepin_arm64_desktop_defconfig to restore built-in EFI framebuffer support.
  • Adjust the defconfig so that systems can light the monitor without requiring a DKMS-installed DRM driver.
arch/arm64/configs/deepin_arm64_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

我来帮你分析这个配置文件的变更:

  1. 语法逻辑:
  • 语法格式正确,符合Linux内核配置文件的规范
  • 配置项的设置方式(y/m)符合标准
  1. 代码质量:
  • 将CONFIG_FB从模块(m)改为内置(y)是一个合理的改动
  • 新增的CONFIG_FB_EFI=y和CONFIG_XEN_FBDEV_FRONTEND=m配置项位置合适,放在了FB相关配置的附近
  1. 性能影响:
  • 将FB从模块改为内置会略微增加内核镜像大小,但可以减少启动时的模块加载时间
  • 对于桌面系统来说,将Framebuffer(FB)编译进内核是合理的选择,因为这是基础的显示功能
  1. 安全性:
  • 这些配置项都是标准配置,不存在安全风险
  • XEN_FBDEV_FRONTEND作为模块加载是合理的选择,只在需要时加载

改进建议:

  1. 考虑添加以下相关配置以完善Framebuffer支持:
CONFIG_FB_SIMPLE=y
CONFIG_FB_ARMCLCD=y
  1. 如果系统支持多个显示器,建议添加:
CONFIG_FB_MULTI_FRAMEBUFFER=y
  1. 为了更好的性能,建议添加:
CONFIG_FB_DEFERRED_IO=y

这些改动都是可选的,取决于具体的硬件需求和使用场景。当前的改动本身是合理的,没有明显的问题。

@deepin-ci-robot deepin-ci-robot requested review from BLumia and myml January 5, 2026 07:59
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cryolitia
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request re-enables EFI framebuffer support in the Deepin ARM64 kernel configuration to provide display output when DKMS DRM drivers are not installed. This ensures the monitor can display output during system startup and in scenarios where advanced graphics drivers are unavailable.

  • Changes framebuffer configuration from module to built-in
  • Enables EFI framebuffer support (CONFIG_FB_EFI)
  • Adds Xen framebuffer frontend support as a module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opsiff opsiff merged commit 628373a into deepin-community:linux-6.6.y Jan 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants