Skip to content

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Jan 6, 2026

…r squashfs

deepin inclusion
category: bugfix

Reenable this config, it help to boost the livecd startup.

Link: #44

Summary by Sourcery

Reenable squashfs multiple decompression support in the deepin ARM64 desktop kernel configuration to improve live CD startup performance.

Bug Fixes:

  • Restore the kernel config option for multiple squashfs decompression methods in the deepin ARM64 desktop defconfig to fix degraded live CD startup behavior.

Build:

  • Adjust the deepin ARM64 desktop defconfig to include squashfs multiple decompression support in kernel builds.

…r squashfs

deepin inclusion
category: bugfix

Reenable this config, it help to boost the livecd startup.

Link: deepin-community#44
Signed-off-by: Wentao Guan <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the deepin ARM64 desktop kernel defconfig to re‑enable SquashFS multi‑decompress support, improving live CD startup performance.

File-Level Changes

Change Details Files
Re-enable SquashFS multi-decompress support in the deepin ARM64 desktop ARM64 defconfig.
  • Set the SquashFS multi-decompress Kconfig option(s) to y or enabled in the defconfig.
  • Ensure the option is included in the built-in configuration for the deepin ARM64 desktop kernel so live CD images benefit at boot.
arch/arm64/configs/deepin_arm64_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

我来帮你分析这个内核配置文件的修改:

  1. 语法逻辑分析:
  • 修改添加了 CONFIG_SQUASHFS_COMPILE_DECOMP_MULTI_PERCPU=y 配置项
  • 语法符合 Linux 内核配置文件的规范,使用了正确的 CONFIG_ 前缀和 =y 赋值格式
  • 位置放置合理,在 SQUASHFS 相关配置组内
  1. 代码质量:
  • 配置项的命名清晰,COMPILE_DECOMP_MULTI_PERCPU 明确表达了其功能:编译时支持多 CPU 解压
  • 放置位置合适,与其他 SQUASHFS 相关配置项保持在一起,便于维护
  1. 性能影响:
  • 这个配置启用后,SquashFS 文件系统将使用多 CPU 并行解压
  • 在多核系统上可以显著提升文件读取性能,特别是在读取压缩文件时
  • 会增加少量内存开销,但在现代多核系统上这个开销是值得的
  1. 安全性:
  • 这个配置项本身不会引入安全风险
  • SquashFS 是一个只读文件系统,本身具有较好的安全性
  • 多 CPU 解压不会影响文件系统的安全性

改进建议:

  1. 考虑添加注释说明启用此配置的原因
  2. 可以评估是否需要同时启用其他相关的多核优化配置项
  3. 建议在相关文档中记录这个配置变更及其性能影响

总的来说,这是一个合理的配置修改,可以提升系统在多核环境下的文件系统性能,特别是在处理 SquashFS 压缩文件时。修改本身没有明显的问题,建议采用。

@Avenger-285714
Copy link
Member

/approve

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables the CONFIG_SQUASHFS_COMPILE_DECOMP_MULTI_PERCPU configuration option in the deepin ARM64 desktop kernel configuration to improve live CD startup performance by enabling per-CPU parallel decompression for SquashFS filesystems.

  • Adds CONFIG_SQUASHFS_COMPILE_DECOMP_MULTI_PERCPU=y to enable per-CPU parallel decompression

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opsiff opsiff changed the title config: deepin_arm64_desktop_defconfig: enable multiple decompress fo… [Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] config: deepin_arm64_desktop_defconfig: enable multiple decompress fo… Jan 6, 2026
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714, Cryolitia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit 04ecf02 into deepin-community:linux-6.6.y Jan 7, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants