Skip to content

Conversation

@lax-fly
Copy link

@lax-fly lax-fly commented Jan 7, 2026

bug details: https://lore.kernel.org/all/[email protected]/

by the way, netdevsim is not switched on in upstream by default, it's already 'n' for loong, arm and riscv in this repository

Summary by Sourcery

Bug Fixes:

  • Turn off netdevsim in the x86 desktop default configuration to avoid triggering the known netdevsim-related bug described upstream.

bug details: https://lore.kernel.org/all/[email protected]/

by the way, netdevsim is not switched on in upstream by default,
it's already 'n' for loong, arm and riscv in this repository

Signed-off-by: xulang <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables the netdevsim-related configuration in the x86 Deepin desktop defconfig to work around a known netdevsim bug, aligning x86 with other architectures where netdevsim is already off by default.

File-Level Changes

Change Details Files
Disable netdevsim (and any associated BPF selftest usage) in the x86 Deepin desktop default kernel configuration to avoid a known upstream bug.
  • Update the deepin_x86_desktop_defconfig to turn off CONFIG_NET_DEVSIM (and, if present, related options such as CONFIG_BPF_SELFTESTS that rely on netdevsim).
  • Align x86 defconfig behavior with loong, arm, and riscv configs where netdevsim is already disabled by default.
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lax-fly lax-fly changed the title [Deepin-Kernel-SIG] [linux 6.12-y] netdevsim&bpf: turn off netdevsim to bypass its bug [Deepin-Kernel-SIG] [linux 6.6-y] netdevsim&bpf: turn off netdevsim to bypass its bug Jan 7, 2026
@deepin-ci-robot
Copy link

Hi @lax-fly. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the netdevsim kernel module in the x86 desktop configuration to work around a known bug in netdevsim. The change references an upstream bug report and aligns the x86 configuration with arm64 and riscv64 architectures where netdevsim is already disabled.

  • Removes CONFIG_NETDEVSIM=m from the x86 desktop default configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit f359c01 into deepin-community:linux-6.6.y Jan 7, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants