deepin: config: check-config.yml: make check for arm64 #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wentao Guan <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow ( No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - name: Install build dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y bc build-essential zstd flex bison libssl-dev make libelf-dev git debhelper pahole libncurses-dev |
There was a problem hiding this comment.
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
|
|
||
| - name: Compare defconfig files (ARM64) | ||
| run: | | ||
| if ! diff -u defconfig defconfig.orig; then |
There was a problem hiding this comment.
WARNING: Possible repeated word: 'defconfig'
deepin pr auto review代码审查意见如下：
综合以上意见，修改后的代码如下： name: Check ARM64 Defconfig Consistency
on:
push:
pull_request:
schedule:
- cron: '0 0 * * *'
jobs:
check-defconfig:
runs-on: ubuntu-24.04-arm
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install build dependencies
run: |
sudo -E apt-get update
sudo -E apt-get install -y bc build-essential zstd flex bison libssl-dev make libelf-dev git debhelper pahole libncurses-dev
- name: Backup original defconfig (ARM64)
run: |
cp -v arch/arm64/configs/deepin_arm64_desktop_defconfig defconfig.orig
- name: Generate new defconfig (ARM64)
run: |
source /etc/profile
make ARCH=arm64 deepin_arm64_desktop_defconfig
make ARCH=arm64 savedefconfig
- name: Compare defconfig files (ARM64)
run: |
if ! diff -u defconfig defconfig.orig; then
echo "::error:: deepin_arm64_desktop_defconfig 文件不一致，请执行 'make savedefconfig' 并提交更新"
exit 1
fi |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @opsiff - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a consistent naming scheme for your workflow files (e.g.,
check-config.ymlandcheck-config-arm64.yml). - The error message is in Chinese; consider providing an English translation for better accessibility.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Avenger-285714 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Check Config Consistency CI for arm64
Summary by Sourcery
CI: