[Deepin-Kernel-SIG] [linux 6.6-y] [Upstream] Update kernel base to 6.6.84

[opsiff]

Update kernel base to 6.6.84.
Handle ("block: fix 'kmem_cache of name 'bio-108' already exists'"): Merged
Handle ("objtool: Ignore dangling jump table entries"):
Context changed because 765ecc2 ("objtool: Handle various symbol types of rodata")
Handle ("stmmac: loongson: Pass correct arg to PCI function"):
Context changed.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the kernel base to 6.6.84, incorporating various bug fixes and improvements across different subsystems, including io_uring, Bluetooth L2CAP, Renesas Sound (RSND), i8042, Intel PMIC, NVMe over Fabrics (nvme-fc), bonding, iqs7222, intel_pmu, AMD display, Marvell 88E6xxx switch, io-wq, ThinkPad ACPI, and xpad.

Sequence diagram for setting convert rate in rsnd_src

sequenceDiagram
    participant rsnd_dai_stream
    participant rsnd_mod
    participant rsnd_src
    participant rsnd_priv

    rsnd_dai_stream->>rsnd_src: rsnd_src_set_convert_rate(io, mod)
    rsnd_src->>rsnd_priv: rsnd_src_get_in_rate(priv, io)
    rsnd_src->>rsnd_priv: rsnd_src_get_out_rate(priv, io)
    alt new_rate != current_sync_rate
        rsnd_src->>rsnd_mod: rsnd_mod_write(SRC_IFSVR, val)
    end
    rsnd_src->>rsnd_src: current_sync_rate = new_rate

Loading

Updated class diagram for rsnd_src

classDiagram
  class rsnd_src {
    -struct rsnd_mod *dma
    -struct rsnd_kctrl_cfg_s sen
    -struct rsnd_kctrl_cfg_s sync
    -u32 current_sync_rate
    -int irq
  }
  rsnd_src : +u32 current_sync_rate
  rsnd_src : +int irq

Loading

Updated class diagram for iqs7222_reg_grp_desc

classDiagram
  class iqs7222_reg_grp_desc {
    u16 base
    u16 val_len
    int num_row
    int num_col
  }
  iqs7222_reg_grp_desc : +u16 val_len

Loading

File-Level Changes

Change	Details	Files
Updates the io_uring subsystem to use vmap and vunmap for mapping user pages, improving memory management and potentially addressing highmem issues on 32-bit architectures.	Replaces folio_put with io_pages_unmap for freeing memory. Introduces io_pages_unmap to unmap and free pages, handling both compound and non-compound pages. Adds io_pin_pages to pin user pages and returns an array of struct page. Modifies __io_uaddr_map to use io_pin_pages and vmap instead of pin_user_pages_fast and direct page address calculations. Updates io_rings_free to use io_pages_unmap for freeing rings and SQEs. Introduces io_pages_map to allocate memory using compound or single pages and map them into kernel space. Removes the io_buf_list and related functions. Updates io_uring_validate_mmap_request to return the mapped address directly. Implements io_uring_mmap_pages to insert pages into a VMA. Modifies io_allocate_scq_urings to use io_pages_map for allocating rings and SQEs when IORING_SETUP_NO_MMAP is not set. Removes highmem checks and discontiguous page support in __io_uaddr_map.	io_uring/io_uring.c io_uring/kbuf.c
Refactors L2CAP channel management to remove unnecessary locking and improve concurrency.	Removes mutex_lock and mutex_unlock calls around __l2cap_get_chan_by_scid and __l2cap_get_chan_by_dcid. Replaces conn->chan_lock with conn->lock in l2cap_chan_timeout, l2cap_chan_add, l2cap_chan_list, l2cap_conn_ready, l2cap_conn_unreliable, l2cap_conn_del, l2cap_raw_recv, l2cap_connect, l2cap_connect_create_rsp, l2cap_disconnect_req, l2cap_disconnect_rsp, l2cap_le_connect_rsp, l2cap_le_connect_req, l2cap_ecred_conn_req, l2cap_ecred_conn_rsp, l2cap_le_command_rej, l2cap_chan_connect, and l2cap_security_cfm. Introduces l2cap_send_acl to check hcon validity before sending ACL packets. Adds l2cap_conn_hold_unless_zero to safely increment the reference count of a connection. Removes hci_cb_lookup and simplifies hci_connect_cfm, hci_disconn_cfm, hci_security_cfm, hci_key_change_cfm, and hci_role_switch_cfm to directly iterate over the hci_cb_list. Removes the match callback from hci_cb and updates the L2CAP callback registration. Adds a mutex to protect the hci_cb_list. Removes unnecessary locking around channel deletion in l2cap_disconnect_req and l2cap_disconnect_rsp. Adds a mutex lock around process_pending_rx to protect the pending RX queue. Adds a check for ACL_LINK and LE_LINK in l2cap_connect_cfm and l2cap_disconn_cfm.	net/bluetooth/l2cap_core.c include/net/bluetooth/hci_core.h net/bluetooth/hci_event.c net/bluetooth/l2cap_sock.c
Updates the Renesas Sound (RSND) driver to improve SRC (Sample Rate Converter) management, including rate setting and synchronization.	Adds current_sync_rate to rsnd_src to track the current synchronization rate. Modifies rsnd_src_convert_rate to use current_sync_rate. Introduces rsnd_src_init_convert_rate to initialize the SRC and set the initial conversion rate. Updates rsnd_src_set_convert_rate to adjust the SRC's SRC_IFSVR register in steps to smoothly transition to the new rate. Adds rsnd_src_kctrl_accept_runtime to check if the kcontrol can be used during runtime. Resets sync.val and current_sync_rate in rsnd_src_init and rsnd_src_quit. Modifies rsnd_src_pcm_new to use rsnd_src_kctrl_accept_runtime and rsnd_src_init_convert_rate.	sound/soc/sh/rcar/src.c
Updates the i8042 ACPI/PNP I/O driver to use SERIO_QUIRK_FORCENORESTORE for certain Clevo laptops, simplifying the quirk configuration.	Replaces `SERIO_QUIRK_NOMUX	SERIO_QUIRK_RESET_ALWAYS
Updates the Intel PMIC core driver to fix a potential integer overflow and improve LTR (Latency Tolerance Reporting) handling.	Changes the type of val to u64 in pmc_core_ltr_show to prevent integer overflow. Adds a check for fb_mmio in vmbus_free_mmio to skip releasing the shadow region if all bytes of the MMIO range are within the shadow region.	drivers/platform/x86/intel/pmc/core.c drivers/hv/vmbus_drv.c
Updates the NVMe over Fabrics (nvme-fc) driver to improve error recovery and association management.	Adds set_bit(ASSOC_FAILED, &ctrl->flags) before calling nvme_reset_ctrl in nvme_fc_ctrl_connectivity_loss. Removes set_bit(ASSOC_FAILED, &ctrl->flags) from nvme_fc_error_recovery. Adds a check for nvme_change_ctrl_state in nvme_fc_create_association and returns an error if the state change fails. Removes NVME_CTRL_RESETTING state change in nvme_fc_init_ctrl.	drivers/nvme/host/fc.c
Updates the bonding driver to correctly set and remove IPv6 Neighbor Solicitation (NS) multicast addresses on slave devices.	Modifies slave_set_ns_maddrs to use addrconf_addr_solict_mult to derive the solicited-node multicast address from the IPv6 target address. Updates slave_set_ns_maddr to use addrconf_addr_solict_mult to derive the solicited-node multicast address from the IPv6 target address.	drivers/net/bonding/bond_options.c
Updates the iqs7222 driver to improve I2C communication and device initialization.	Updates iqs7222_read_burst and iqs7222_write_burst to use val_len instead of num_val * sizeof(__le16) for message length. Updates iqs7222_dev_init to use val_len from dev_desc->reg_grps for burst read/write operations. Removes unnecessary filter setup code in iqs7222_dev_init. Updates iqs7222_dev_info to use sizeof(dev_id) instead of ARRAY_SIZE(dev_id) in iqs7222_read_burst.	drivers/input/misc/iqs7222.c
Updates the intel_pmu driver to improve frequency sampling and start period calculations.	Adds intel_pmu_freq_start_period to calculate the start period for frequency sampling based on event type and frequency. Updates intel_pmu_hw_config to set event->hw.sample_period and event->hw.last_period using intel_pmu_freq_start_period when frequency sampling is enabled.	arch/x86/events/intel/core.c
Updates the io_uring subsystem to improve resource management and error handling.	Fixes a potential memory leak by adding a goto statement to free resources on error in io_sqe_buffer_register. Removes the mmap_read_lock and mmap_read_unlock calls from io_pin_pages.	io_uring/rsrc.c
Updates the nvme-tcp driver to handle C2HTermReq PDUs and improve error reporting.	Adds nvme_tcp_handle_c2h_term to handle C2HTermReq PDUs and log error messages. Modifies nvme_tcp_recv_pdu to handle C2HTermReq PDUs and skip digest checks. Adds nvmet_rdma_recv_not_live to handle the case where the queue is not live.	drivers/nvme/host/tcp.c
Updates the mm subsystem to deprecate remap_file_pages() syscall and improve security checks.	Adds a warning message about the deprecated remap_file_pages() syscall. Improves security checks by performing initial checks under read lock and rechecking under write lock. Adds fput(file) calls to release the file object in various error paths.	mm/mmap.c
Updates the AMD display driver to improve HPD (Hot Plug Detect) interrupt handling and fix a potential race condition.	Clears all HPD and HPDRX interrupts during initialization. Modifies amdgpu_dm_hpd_init and amdgpu_dm_hpd_fini to use amdgpu_irq_get/put for HPD interrupts and dc_interrupt_set for HPD_RX interrupts. Adds a check in amdgpu_dm_hpd_init to skip connection status notifications (CSN) before topology probing is complete.	drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
Updates the Marvell 88E6xxx switch driver to fix FDB (Forwarding Database) entry addition and improve VLAN handling.	Adds a check after calling mv88e6xxx_port_db_load_purge in mv88e6xxx_port_fdb_add and mv88e6xxx_port_mdb_add to verify that the entry was successfully added. Introduces mv88e6xxx_port_db_get to retrieve ATU entries based on MAC address and VLAN ID. Introduces mv88e6xxx_port_db_find to check if a MAC address exists in the ATU database for a given VLAN ID.	drivers/net/dsa/mv88e6xxx/chip.c
Updates the io_uring subsystem to improve worker thread management and retry logic.	Changes worker->work from struct work_struct to struct delayed_work. Introduces queue_create_worker_retry to schedule a delayed work item for retrying worker creation. Replaces schedule_work with queue_create_worker_retry in create_worker_cont and create_io_worker.	io_uring/io-wq.c
Updates the ThinkPad ACPI driver to add a quirk for fan speed in Ticks Per Revolution (TPR) and improve DYTC (Dynamic Thermal Control) profile handling.	Adds fan_speed_in_tpr to indicate if the fan speed is in Ticks Per Revolution. Adds TPACPI_FAN_TPR quirk for ThinkPad x120e. Modifies fan_get_speed and fan2_get_speed to convert fan speed from TPR to RPM if fan_speed_in_tpr is set. Adds a check for DYTC version in tpacpi_dytc_profile_init and updates profiles for DYTC 9 and up.	drivers/platform/x86/thinkpad_acpi.c
Updates the xpad driver to add support for new gamepads and improve device identification.	Adds device IDs for various new gamepads, including ThrustMaster, Mad Catz, PDP, Hori, Turtle Beach, TECNO, Hyperkin, and Nacon controllers. Updates device type assignments for certain controllers.	drivers/input/joystick/xpad.c
Updates the L2CAP core to fix a potential double free in l2cap_sock_shutdown.	Adds a check for chan before calling l2cap_chan_hold in l2cap_sock_shutdown to avoid dereferencing a NULL pointer. Adds l2cap_conn_hold_unless_zero to safely increment the reference count of a connection.	net/bluetooth/l2cap_sock.c
Updates the iqs7222 driver to improve I2C communication and device initialization.	Updates iqs7222_read_burst and iqs7222_write_burst to use val_len instead of num_val * sizeof(__le16) for message length. Updates iqs7222_dev_init to use val_len from dev_desc->reg_grps for burst read/write operations. Removes unnecessary filter setup code in iqs7222_dev_init. Updates iqs7222_dev_info to use sizeof(dev_id) instead of ARRAY_SIZE(dev_id) in iqs7222_read_burst.	drivers/input/misc/iqs7222.c
Updates the io_uring subsystem to improve resource management and error handling.	Fixes a potential memory leak by adding a goto statement to free resources on error in io_sqe_buffer_register. Removes the mmap_read_lock and mmap_read_unlock calls from io_pin_pages.	io_uring/rsrc.c
Updates the nvme-tcp driver to handle C2HTermReq PDUs and improve error reporting.	Adds nvme_tcp_handle_c2h_term to handle C2HTermReq PDUs and log error messages. Modifies nvme_tcp_recv_pdu to handle C2HTermReq PDUs and skip digest checks. Adds nvmet_rdma_recv_not_live to handle the case where the queue is not live.	drivers/nvme/host/tcp.c
Updates the mm subsystem to deprecate remap_file_pages() syscall and improve security checks.	Adds a warning message about the deprecated remap_file_pages() syscall. Improves security checks by performing initial checks under read lock and rechecking under write lock. Adds fput(file) calls to release the file object in various error paths.	mm/mmap.c
Updates the AMD display driver to improve HPD (Hot Plug Detect) interrupt handling and fix a potential race condition.	Clears all HPD and HPDRX interrupts during initialization. Modifies amdgpu_dm_hpd_init and amdgpu_dm_hpd_fini to use amdgpu_irq_get/put for HPD interrupts and dc_interrupt_set for HPD_RX interrupts. Adds a check in amdgpu_dm_hpd_init to skip connection status notifications (CSN) before topology probing is complete.	drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
Updates the Marvell 88E6xxx switch driver to fix FDB (Forwarding Database) entry addition and improve VLAN handling.	Adds a check after calling mv88e6xxx_port_db_load_purge in mv88e6xxx_port_fdb_add and mv88e6xxx_port_mdb_add to verify that the entry was successfully added. Introduces mv88e6xxx_port_db_get to retrieve ATU entries based on MAC address and VLAN ID. Introduces mv88e6xxx_port_db_find to check if a MAC address exists in the ATU database for a given VLAN ID.	drivers/net/dsa/mv88e6xxx/chip.c
Updates the io_uring subsystem to improve worker thread management and retry logic.	Changes worker->work from struct work_struct to struct delayed_work. Introduces queue_create_worker_retry to schedule a delayed work item for retrying worker creation. Replaces schedule_work with queue_create_worker_retry in create_worker_cont and create_io_worker.	io_uring/io-wq.c
Updates the ThinkPad ACPI driver to add a quirk for fan speed in Ticks Per Revolution (TPR) and improve DYTC (Dynamic Thermal Control) profile handling.	Adds fan_speed_in_tpr to indicate if the fan speed is in Ticks Per Revolution. Adds TPACPI_FAN_TPR quirk for ThinkPad x120e. Modifies fan_get_speed and fan2_get_speed to convert fan speed from TPR to RPM if fan_speed_in_tpr is set. Adds a check for DYTC version in tpacpi_dytc_profile_init and updates profiles for DYTC 9 and up.	drivers/platform/x86/thinkpad_acpi.c
Updates the xpad driver to add support for new gamepads and improve device identification.	Adds device IDs for various new gamepads, including ThrustMaster, Mad Catz, PDP, Hori, Turtle Beach, TECNO, Hyperkin, and Nacon controllers. Updates device type assignments for certain controllers.	drivers/input/joystick/xpad.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• In l2cap_core.c, the removal of mutex_lock and mutex_unlock around calls to __l2cap_get_chan_by_scid and __l2cap_get_chan_by_dcid might introduce race conditions if these functions are not thread-safe; ensure that the underlying data structures are protected appropriately.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 2 issues found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

question (performance): Switching the hci callback list protection from RCU to a mutex could affect concurrency.

Confirm that moving to mutex-based protection will not negatively impact read-side performance, especially if hci callbacks are frequently accessed, and that any potential ordering differences are acceptable.

[sourcery-ai]

issue (complexity): Consider consolidating the page allocation logic into a single helper function to reduce code duplication and simplify error handling in the mapping helpers, such as io_pages_map().

Consider consolidating the error handling and page‐allocation paths in the mapping helpers. For example, since both io_mem_alloc_compound() and io_mem_alloc_single() share similar cleanup logic, you might create a single allocation helper that accepts a flag to indicate whether to try compound allocation first and then fall back to single‐page allocation. This removes duplicate branches and nested error handling.

For example:

static void *io_mem_alloc_pages(struct page **pages, int nr_pages, size_t size,
                                gfp_t gfp, bool try_compound)
{
    void *ret;

    if (try_compound) {
        ret = io_mem_alloc_compound(pages, nr_pages, size, gfp);
        if (!IS_ERR(ret))
            return ret;
    }

    ret = io_mem_alloc_single(pages, nr_pages, size, gfp);
    if (!IS_ERR(ret))
        return ret;

    /* Cleanup if allocation failed */
    kvfree(pages);
    return ret;
}

Then update io_pages_map() to use this new helper:

void *io_pages_map(struct page ***out_pages, unsigned short *npages, size_t size)
{
    gfp_t gfp = GFP_KERNEL_ACCOUNT | __GFP_ZERO | __GFP_NOWARN;
    int nr_pages = (size + PAGE_SIZE - 1) >> PAGE_SHIFT;
    struct page **pages = kvmalloc_array(nr_pages, sizeof(struct page *), gfp);
    void *ret;

    if (!pages)
        return ERR_PTR(-ENOMEM);

    ret = io_mem_alloc_pages(pages, nr_pages, size, gfp, true);
    if (!IS_ERR(ret)) {
        *out_pages = pages;
        *npages = nr_pages;
        return ret;
    }

    *out_pages = NULL;
    *npages = 0;
    return ret;
}

These changes reduce nesting and duplicate error paths while keeping functionality intact.

[sourcery-ai]

issue (complexity): Consider using inline helper functions to abstract connection reference management and simplify the code where connections are used, without changing the current functionality

Consider abstracting connection reference management into inline helper functions (or a dedicated module) to keep the consuming code simple. For example, replace the two functions with an abstraction API such as:

```c
static inline void ksmbd_conn_get(struct ksmbd_conn *conn)
{
    /* Increase use-count */
    atomic_inc(&conn->r_count);
}

static inline void ksmbd_conn_put(struct ksmbd_conn *conn)
{
    /* Increase overall ref count before dropping */
    atomic_inc(&conn->refcnt);

    /* Decrement request count and wake waiter if needed */
    if (!atomic_dec_return(&conn->r_count) && waitqueue_active(&conn->r_count_q))
        wake_up(&conn->r_count_q);

    /* Free connection if overall count goes to zero */
    if (atomic_dec_and_test(&conn->refcnt))
        kfree(conn);
}

Then update all calls to use ksmbd_conn_get() and ksmbd_conn_put() so that connection reference management logic is isolated. This reduces branching complexity in places where managing references is used without reverting current functionality.

[Avenger-285714]

/approve