feat(qe): Add support for ibrav > 1 in Quantum Espresso SCF parser #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the long-standing limitation where dpdata would raise
RuntimeError("ibrav > 1 not supported yet.")
when parsing Quantum Espresso SCF files with Bravais lattice types other than simple cubic (ibrav=1) or free lattice (ibrav=0).Problem
Users encountered errors when trying to load QE files with common lattice types like:
This occurred for any ibrav value > 1, including commonly used types like ibrav=8 (simple orthorhombic).
Solution
Extended the
get_cell()
function indpdata/qe/scf.py
to support all standard Quantum Espresso lattice types (ibrav 1-14):The implementation:
Testing
Added comprehensive test suite covering:
Example usage that now works:
Fixes #408.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.