Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

The model_devi_e_trust_lo and model_devi_e_trust_hi parameters have been deprecated in dpgen run but still exist in example configurations.

Changes

  • Removed model_devi_e_trust_lo and model_devi_e_trust_hi from 3 files in examples/run/:

    • dp-calypso-vasp/param.json
    • deprecated/dp2.x-lammps-vasp/Al/param_al_all_gpu.yaml
    • deprecated/dp2.x-lammps-vasp/CH4/param_CH4.yaml
  • Preserved parameters in dpgen simplify module and tests where still supported

Example

 "model_devi_dt": 0.002,
 "model_devi_skip": 0,
 "model_devi_f_trust_lo": 0.05,
 "model_devi_f_trust_hi": 0.15,
-"model_devi_e_trust_lo": 10000000000.0,
-"model_devi_e_trust_hi": 10000000000.0,
 "model_devi_clean_traj": true,
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove model_devi_e_trust_lo and model_devi_e_trust_hi from dpgen run examples</issue_title>
<issue_description>### Summary

Remove model_devi_e_trust_lo and model_devi_e_trust_hi from dpgen run examples, since they have been removed.

Do not remove them from dpgen simplify examples, since they are still supported in dpgen simplify.

DP-GEN Version

Platform, Python Version, etc

Details

-</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove model_devi_e_trust_lo and model_devi_e_trust_hi from dpgen run examples Remove deprecated model_devi_e_trust_lo/hi from dpgen run examples Dec 31, 2025
Copilot AI requested a review from njzjz December 31, 2025 07:09
@njzjz njzjz marked this pull request as ready for review December 31, 2025 07:10
Copilot AI review requested due to automatic review settings December 31, 2025 07:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated model_devi_e_trust_lo and model_devi_e_trust_hi parameters from dpgen run example configurations, as these parameters are no longer supported in the dpgen run command.

Key changes:

  • Removed model_devi_e_trust_lo and model_devi_e_trust_hi from three example configuration files under examples/run/
  • Parameters correctly preserved in dpgen simplify module where they remain supported

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/run/dp-calypso-vasp/param.json Removed deprecated energy trust parameters from CALYPSO-VASP example configuration
examples/run/deprecated/dp2.x-lammps-vasp/CH4/param_CH4.yaml Removed deprecated energy trust parameters from CH4 YAML configuration
examples/run/deprecated/dp2.x-lammps-vasp/Al/param_al_all_gpu.yaml Removed deprecated energy trust parameters from Al GPU YAML configuration

Review Summary: The changes are clean and consistent. All three files correctly remove only the deprecated model_devi_e_trust_lo and model_devi_e_trust_hi parameters while preserving all other configuration settings. The JSON/YAML syntax remains valid after the removals. Verification confirms no remaining occurrences of these parameters exist in examples/run/ directory, and they are correctly preserved in the dpgen simplify module where they remain supported.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.80%. Comparing base (037d6b8) to head (f3b16fe).
⚠️ Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1853   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          83       83           
  Lines       14988    14988           
=======================================
  Hits         7465     7465           
  Misses       7523     7523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz njzjz changed the title Remove deprecated model_devi_e_trust_lo/hi from dpgen run examples docs: remove deprecated model_devi_e_trust_lo/hi from dpgen run examples Dec 31, 2025
@njzjz njzjz requested a review from wanghan-iapcm December 31, 2025 12:44
@wanghan-iapcm wanghan-iapcm merged commit 37b8072 into devel Jan 3, 2026
21 checks passed
@wanghan-iapcm wanghan-iapcm deleted the copilot/remove-deprecated-models branch January 3, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove model_devi_e_trust_lo and model_devi_e_trust_hi from dpgen run examples

3 participants