-
Notifications
You must be signed in to change notification settings - Fork 4
fix(deps): update dependency react-svg-pan-zoom to v3.13.1 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 55 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated dependency in package.json: the Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
c0cc58c to
6daee7b
Compare
a51c4c9 to
7058c31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6cfd3ca to
ab4c27e
Compare
1a8e102 to
c579ccd
Compare
c3b1562 to
5e91033
Compare
f7e96b2 to
abbd583
Compare
c3d23fd to
93094ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build & Test
- GitHub Check: Lint & Format
| "react-error-boundary": "^6.0.0", | ||
| "react-redux": "^7.1.1", | ||
| "react-svg-pan-zoom": "3.9.0", | ||
| "react-svg-pan-zoom": "3.13.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# First, check the React version specified in package.json
grep -n '"react"' package.json | head -5Repository: deepnote/vscode-deepnote
Length of output: 100
🏁 Script executed:
# Check if the three mentioned component files exist
fd -t f '\.(tsx|ts|jsx|js)$' | grep -E '(svgViewer|toolbar|mainPanel)' | head -20Repository: deepnote/vscode-deepnote
Length of output: 262
🏁 Script executed:
# Search for react-svg-pan-zoom imports in the codebase
rg 'react-svg-pan-zoom' -t ts -t tsx -t js -t jsx -A 2 -B 2Repository: deepnote/vscode-deepnote
Length of output: 95
🌐 Web query:
react-svg-pan-zoom 3.10 React version requirement compatibility
💡 Result:
react-svg-pan-zoom v3.10 migrated the library to React 17 — so v3.10 expects React 17 (and may not be fully compatible with older React 16 installs). [1][2]
Sources:
- GitHub changelog (v3.10: "Migrates to React 17"). [1]
- npm package changelog/description for v3.x. [2]
🏁 Script executed:
# Retry searching for react-svg-pan-zoom imports with correct file type
rg 'react-svg-pan-zoom' --type=typescript --type=tsx -A 2 -B 2Repository: deepnote/vscode-deepnote
Length of output: 102
🌐 Web query:
react-svg-pan-zoom 3.13.1 React version requirement
💡 Result:
react-svg-pan-zoom v3.13.1 is compatible with React 17 (the v3.x line migrated to React 17 at v3.10), and the package’s peer dependency has historically been "react": ">=16.0.0". [1][2]
Sources:
- Changelog / README (migration to React 17 noted at v3.10 and v3.13 release info). [1]
- package.json (peerDependencies: "react": ">=16.0.0" shown in package metadata). [2]
References:
[1] GitHub repo changelog/README for react-svg-pan-zoom.
[2] react-svg-pan-zoom package.json metadata (example: v3.2.0 listing peerDependencies).
🏁 Script executed:
# Search for react-svg-pan-zoom imports in component files directly
cat src/webviews/webview-side/plot/toolbar.tsx | grep -i 'react-svg-pan-zoom' || echo "Not found in toolbar.tsx"
cat src/webviews/webview-side/react-common/svgViewer.tsx | grep -i 'react-svg-pan-zoom' || echo "Not found in svgViewer.tsx"
cat src/webviews/webview-side/plot/mainPanel.tsx | grep -i 'react-svg-pan-zoom' || echo "Not found in mainPanel.tsx"Repository: deepnote/vscode-deepnote
Length of output: 241
🌐 Web query:
react-svg-pan-zoom v3.13 React 16 compatibility issues known problems
💡 Result:
Short answer — yes, there are known compatibility pain points when using react-svg-pan-zoom 3.x with older React (16):
- The library migrated to React 17 in v3.10, so later 3.x releases assume newer React ecosystem; that can surface subtle incompatibilities running on React 16. (github.com)
- Historically CRA/production builds pulled the package’s UMD bundle (which caused runtime issues). The recommended workaround is to import the ES build explicitly:
import { UncontrolledReactSVGPanZoom } from 'react-svg-pan-zoom/build-es'. (stackoverflow.com) - v3.13 removed deprecated defaultProps and upgraded deps/Storybook; those breaking cleanups can affect older code paths that relied on removed defaults or older React behavior. (github.com)
If you need, tell me your exact react-svg-pan-zoom version and React 16.x patch (16.8/16.13/etc.) and I’ll give concrete fixes or a minimal patch (imports, polyfills, or pinning a 2.x release).
Citations:
- 1: https://github.com/chrvadala/react-svg-pan-zoom?utm_source=openai
- 2: https://stackoverflow.com/questions/55107170/react-svg-pan-zoom-problem-with-production-version-serve-build?utm_source=openai
- 3: https://github.com/chrvadala/react-svg-pan-zoom?utm_source=openai
CRITICAL: React 16 compatibility issues with react-svg-pan-zoom v3.13.1.
Upgrading from 3.9.0 to 3.13.1 introduces real compatibility problems with React 16.5.2. The library migrated to React 17 at v3.10, and v3.13.1 removed deprecated features (defaultProps, upgraded deps) that create subtle incompatibilities on React 16. Known issues include UMD bundle failures and breaking changes that will affect svgViewer.tsx, toolbar.tsx, and mainPanel.tsx.
Resolution options:
- Revert to 3.9.x (compatible with React 16.5.2)
- Upgrade React to 17+ and test all affected components thoroughly
- If staying on 3.13.1 with React 16, switch to explicit ES build imports:
'react-svg-pan-zoom/build-es'
Verify the chosen path and test affected components before merging.
🤖 Prompt for AI Agents
In package.json at line ~2550, the upgrade of react-svg-pan-zoom to 3.13.1
breaks compatibility with React 16.5.2; to fix this either (A) pin
react-svg-pan-zoom back to a 3.9.x release (e.g., 3.9.0) in package.json, run
npm/yarn install and run the UI tests and manually verify svgViewer.tsx,
toolbar.tsx and mainPanel.tsx; or (B) if you prefer the newer lib, upgrade the
app to React 17+ and run full component tests; or (C) as a minimal compatibility
workaround keep React 16 and change imports in affected components to use the ES
build import path ('react-svg-pan-zoom/build-es'), then run installs and test
those components before merging.
86e6cc2 to
40378c8
Compare
40378c8 to
43ae55a
Compare
This PR contains the following updates:
3.9.0->3.13.1Release Notes
chrvadala/react-svg-pan-zoom (react-svg-pan-zoom)
v3.13.1Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.13.0Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.12.1Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.12.0Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.11.0: Release 3.11.0Compare Source
Release 3.11.0
v3.10.0: Release 3.10.0Compare Source
Release 3.10.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.