Skip to content

chore(deps): update node.js to v24 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): update node.js to v24 #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.21.1
24.13.0
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for Node version references across the repository

echo "=== package.json engines field ==="
fd -t f 'package\.json$' --exec jq -r '{file: input_filename, engines: .engines}' {} \; 2>/dev/null | head -50

echo -e "\n=== GitHub Actions workflows (node-version references) ==="
rg 'node-version' -g '*.yml' -g '*.yaml' --max-count 10 2>/dev/null

echo -e "\n=== .nvmrc files ==="
fd -t f '\.nvmrc$' --exec cat {} + | wc -l
fd -t f '\.nvmrc$' -exec sh -c 'echo "File: {}"; cat {}' \;

echo -e "\n=== package.json with `@types/node` versions ==="
fd -t f 'package\.json$' --exec jq -r 'select(.devDependencies."@types/node" != null or .dependencies."@types/node" != null) | {file: input_filename, types_node: (.devDependencies."@types/node" // .dependencies."@types/node")}' {} \; 2>/dev/null

echo -e "\n=== Node version mentions in docs ==="
rg 'node.*24|24.*node' -i -g '*.md' 2>/dev/null | head -20

Repository: deepnote/vscode-deepnote

Length of output: 891

🌐 Web query:

Node.js 24.13.0 release security CVE 2026

💡 Result:

Yes — Node.js 24.13.0 (LTS) is a security release published on January 13, 2026. It fixes multiple CVEs (notably CVE-2025-55131, CVE-2025-55130 and CVE-2025-59465 among others) and the Node.js project recommends upgrading to 24.13.0 (or later) to address these issues. [1][2]

Sources:

  • Node.js 24.13.0 release notes (Jan 13, 2026). [1]
  • Node.js security releases advisory (Jan 13, 2026) — list of addressed CVEs and upgrade guidance. [2]

🌐 Web query:

@types/node 24 TypeScript types Node.js compatibility

💡 Result:

Short answer: @types/node v24 = type definitions for Node.js 24 (match major versions). Use the @types major that matches your Node major (e.g., install @types/node@24 for Node 24). For runtime TypeScript in Node 24, Node's docs recommend TypeScript 5.8+ for the built‑in type‑stripping workflow. [1][2][3]

Sources:

  • DefinitelyTyped/@types versioning and guidance. [1]
  • Explanation that @types/node major aligns with Node major. [2]
  • Node.js TypeScript (type‑stripping) guidance recommending TS 5.8+ (Node 24 docs). [3]

Update @types/node to match Node.js 24—version mismatch detected.

Node.js 24.13.0 is valid and addresses multiple CVEs (recommended upgrade). However, package.json still has @types/node ^22.15.1. Update to @types/node ^24.x to match the Node 24.13.0 runtime, preventing TypeScript compilation issues.

Also update the test package's @types/node ^18.15.0 to ^24.x for consistency.

🤖 Prompt for AI Agents 
In @.nvmrc at line 1, Update the `@types/node` versions to match Node.js 24:
change the root package.json dependency "@types/node" from "^22.15.1" to "^24.x"
and update the test package's "@types/node" from "^18.15.0" to "^24.x"; run npm
install (or yarn) and then rebuild/typecheck to ensure no type errors, and
update any lockfile (package-lock.json / yarn.lock) accordingly.

2 changes: 1 addition & 1 deletion src/test/vscode-notebook-perf/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.21.1
24.13.0
Loading