Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 18, 2025

Note: This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
@tailwindcss/postcss (source) 4.1.14 -> 4.1.17 age confidence
@typescript-eslint/eslint-plugin (source) 6.9.0 -> 6.21.0 age confidence
@typescript-eslint/eslint-plugin-tslint (source) 6.9.0 -> 6.21.0 age confidence
@typescript-eslint/parser (source) 6.9.0 -> 6.21.0 age confidence
@vscode/dts 0.4.0 -> 0.4.1 age confidence
@vscode/test-cli ^0.0.8 -> ^0.0.12 age confidence
@vscode/test-electron 2.3.9 -> 2.5.2 age confidence
@vscode/test-web ^0.0.71 -> ^0.0.77 age confidence
acorn 8.9.0 -> 8.15.0 age confidence
autoprefixer 10.4.21 -> 10.4.22 age confidence
bare-events 2.8.1 -> 2.8.2 age confidence
bufferutil 4.0.6 -> 4.0.9 age confidence
chai (source) 4.3.10 -> 4.5.0 age confidence
chai-as-promised 7.1.1 -> 7.1.2 age confidence
chai-exclude 2.1.0 -> 2.1.1 age confidence
cspell (source) 9.2.1 -> 9.4.0 age confidence
es-abstract 1.22.3 -> 1.24.0 age confidence
es5-ext 0.10.63 -> 0.10.64 age confidence
esbuild ^0.25.1 -> ^0.27.0 age confidence
esbuild-plugin-less 1.3.19 -> 1.3.33 age confidence
eslint (source) 8.52.0 -> 8.57.1 age confidence
eslint-config-prettier 9.0.0 -> 9.1.2 age confidence
eslint-plugin-import 2.29.0 -> 2.32.0 age confidence
eslint-plugin-jsdoc 46.8.2 -> 46.10.1 age confidence
eslint-plugin-jsx-a11y 6.7.1 -> 6.10.2 age confidence
eslint-plugin-no-only-tests (source) 3.1.0 -> 3.3.0 age confidence
eslint-plugin-prettier 5.0.1 -> 5.5.4 age confidence
eslint-plugin-react 7.33.2 -> 7.37.5 age confidence
eslint-plugin-react-hooks (source) 4.6.0 -> 4.6.2 age confidence
gulp (source) 5.0.0 -> 5.0.1 age confidence
gulp-rename 2.0.0 -> 2.1.0 age confidence
jsonschema 1.4.1 -> 1.5.0 age confidence
less (source) 4.2.2 -> 4.4.2 age confidence
lint-staged 16.2.3 -> 16.2.7 age confidence
lru-cache 10.2.0 -> 10.4.3 age confidence
mocha (source) 11.0.1 -> 11.7.5 age confidence
mocha-junit-reporter 2.2.0 -> 2.2.1 age confidence
prettier (source) 3.0.0 -> 3.7.4 age confidence
rimraf 5.0.1 -> 5.0.10 age confidence
screenshot-desktop 1.15.2 -> 1.15.3 age confidence
source-map 0.7.4 -> 0.7.6 age confidence
tailwindcss (source) 4.1.14 -> 4.1.17 age confidence
ts-mock-imports 1.3.8 -> 1.3.19 age confidence
tsx (source) 4.19.4 -> 4.21.0 age confidence
typescript (source) 5.4.5 -> 5.9.3 age confidence
typescript (source) 5.8.3 -> 5.9.3 age confidence
unicode-properties 1.3.1 -> 1.4.1 age confidence
utf-8-validate 5.0.9 -> 5.0.10 age confidence

Release Notes

tailwindlabs/tailwindcss (@​tailwindcss/postcss)

v4.1.17

Compare Source

Fixed
  • Substitute @variant inside legacy JS APIs (#​19263)
  • Prevent occasional crash on Windows when loaded into a worker thread (#​19242)

v4.1.16

Compare Source

Fixed
  • Discard candidates with an empty data type (#​19172)
  • Fix canonicalization of arbitrary variants with attribute selectors (#​19176)
  • Fix invalid colors due to nested & (#​19184)
  • Improve canonicalization for & > :pseudo and & :pseudo arbitrary variants (#​19178)

v4.1.15

Compare Source

Fixed
  • Fix Safari devtools rendering issue due to color-mix fallback (#​19069)
  • Suppress Lightning CSS warnings about :deep, :slotted, and :global (#​19094)
  • Fix resolving theme keys when starting with the name of another theme key in JS configs and plugins (#​19097)
  • Allow named groups in combination with not-*, has-*, and in-* (#​19100)
  • Prevent important utilities from affecting other utilities (#​19110)
  • Don’t index into strings with the theme(…) function (#​19111)
  • Fix parsing issue when \t is used in at-rules (#​19130)
  • Upgrade: Canonicalize utilities containing 0 values (#​19095)
  • Upgrade: Migrate deprecated break-words to wrap-break-word (#​19157)
Changed
typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)

v6.21.0

Compare Source

🚀 Features
  • export plugin metadata

  • allow parserOptions.project: false

  • eslint-plugin: add rule prefer-find

🩹 Fixes
  • eslint-plugin: [no-unused-vars] don't report on types referenced in export assignment expression

  • eslint-plugin: [switch-exhaustiveness-check] better support for intersections, infinite types, non-union values

  • eslint-plugin: [consistent-type-imports] dont report on types used in export assignment expressions

  • eslint-plugin: [no-unnecessary-condition] handle left-hand optional with exactOptionalPropertyTypes option

  • eslint-plugin: [class-literal-property-style] allow getter when same key setter exists

  • eslint-plugin: [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before as keyword

❤️ Thank You
  • auvred
  • Brad Zacher
  • Kirk Waiblinger
  • Pete Gonzalez
  • YeonJuan

You can read about our versioning strategy and releases on our website.

v6.20.0

Compare Source

🚀 Features
  • eslint-plugin: [member-ordering] allow easy reuse of the default ordering
🩹 Fixes
  • eslint-plugin: [no-useless-template-literals] incorrect bigint autofix result

  • eslint-plugin: [prefer-nullish-coalescing] treat any/unknown as non-nullable

  • eslint-plugin: [no-useless-template-literals] report Infinity & NaN

  • eslint-plugin: [prefer-readonly] disable checking accessors

❤️ Thank You
  • Alex Parloti
  • auvred
  • James Browning
  • StyleShit
  • YeonJuan

You can read about our versioning strategy and releases on our website.

v6.19.1

Compare Source

🩹 Fixes
  • type-utils: preventing isUnsafeAssignment infinite recursive calls

  • eslint-plugin: [no-unnecessary-condition] fix false positive for type variable

❤️ Thank You
  • YeonJuan

You can read about our versioning strategy and releases on our website.

v6.19.0

Compare Source

🚀 Features
  • eslint-plugin: [prefer-promise-reject-errors] add rule

  • eslint-plugin: [no-array-delete] add new rule

  • eslint-plugin: [no-useless-template-literals] add fix suggestions

🩹 Fixes
  • eslint-plugin: [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression

  • eslint-plugin: [no-unnecesary-type-assertion] treat unknown/any as nullable

❤️ Thank You
  • auvred
  • Brad Zacher
  • Josh Goldberg ✨
  • Joshua Chen
  • LJX
  • Steven
  • StyleShit

You can read about our versioning strategy and releases on our website.

v6.18.1

Compare Source

🩹 Fixes
  • eslint-plugin: [no-non-null-assertion] provide valid fix when member access is on next line

  • eslint-plugin: [no-unnecessary-condition] improve checking optional callee

  • eslint-plugin: [prefer-readonly] support modifiers of unions and intersections

  • eslint-plugin: [switch-exhaustiveness-check] fix new allowDefaultCaseForExhaustiveSwitch option

❤️ Thank You
  • auvred
  • James
  • Josh Goldberg ✨
  • YeonJuan

You can read about our versioning strategy and releases on our website.

v6.18.0

Compare Source

🚀 Features
  • typescript-estree: throw on invalid update expressions

  • eslint-plugin: [no-var-requires, no-require-imports] allow option

❤️ Thank You
  • auvred
  • Joshua Chen

You can read about our versioning strategy and releases on our website.

v6.17.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-restricted-imports] prevent crash when patterns or paths in options are empty (#​8108) (675e987)
Features
  • eslint-plugin: [no-floating-promises] flag result of .map(async) (#​7897) (5857356)
  • eslint-plugin: [switch-exhaustiveness-check] add an option to warn against a default case on an already exhaustive switch (#​7539) (6a219bd)

You can read about our versioning strategy and releases on our website.

v6.16.0

Compare Source

Bug Fixes
  • eslint-plugin: [unbound-method] exempt all non-Promise built-in statics (#​8096) (3182959)
Features
  • eslint-plugin: deprecate formatting (meta.type: layout) rules (#​8073) (04dea84)
  • eslint-plugin: deprecate no-extra-semi in favor of ESLint Stylistic equivalent (#​8123) (9368bf3)

You can read about our versioning strategy and releases on our website.

v6.15.0

Compare Source

Features

You can read about our versioning strategy and releases on our website.

v6.14.0

Compare Source

Bug Fixes
  • eslint-plugin: add no-unsafe-unary-minus, prefer-destructuring to disable-type-checked (#​8038) (431cd15)
  • eslint-plugin: correct message for no-unsafe-unary-minus (#​7998) (705370a)
Features
  • eslint-plugin: [explicit-function-return-type] add support for typed class property definitions (#​8027) (bff47d7)
  • eslint-plugin: [require-await] allow yielding Promise in async generators (#​8003) (4c3e704)

You can read about our versioning strategy and releases on our website.

6.13.2 (2023-12-04)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

6.13.1 (2023-11-28)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v6.13.2

Compare Source

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v6.13.1

Compare Source

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v6.13.0

Compare Source

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v6.12.0

Compare Source

Bug Fixes
  • eslint-plugin: [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set (#​7705) (155aa1f)
  • eslint-plugin: [no-unnecessary-condition] fix false positive with computed member access and branded key type (#​7706) (f151b26)
  • eslint-plugin: [switch-exhaustiveness-check] enum members with new line or single quotes are not being fixed correctly (#​7806) (a034d0a), closes #​7768
Features
  • [member-ordering] add accessor support for member-ordering (#​7927) (3c8312d)
  • eslint-plugin: [switch-exhaustiveness-check] add requireDefaultForNonUnion option (#​7880) (4cfcd45)

You can read about our versioning strategy and releases on our website.

v6.11.0

Compare Source

Bug Fixes
  • eslint-plugin: [explicit-function-return-type] support JSX attributes in allowTypedFunctionExpressions (#​7553) (be2777c)
  • eslint-plugin: [no-unnecessary-qualifier] handle nested namespace id (#​7883) (a668f5b)
Features

You can read about our versioning strategy and releases on our website.

v6.10.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-unused-vars] handle logical assignment (#​7854) (11e57c5)
  • eslint-plugin: [require-await] add support for "await using" (#​7866) (855abea)
Features
  • eslint-plugin: [ban-ts-comments] suggest ts-expect-error over ts-ignore (#​7849) (5e73a48)

You can read about our versioning strategy and releases on our website.

6.9.1 (2023-10-30)

Bug Fixes
  • eslint-plugin: [naming-convention] allow PascalCase for imports (#​7841) (7ad86ee)
  • eslint-plugin: [no-unused-expressions] handle TSInstantiationExpression expression (#​7831) (31988e0)

You can read about our versioning strategy and releases on our website.

v6.9.1

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] allow PascalCase for imports (#​7841) (7ad86ee)
  • eslint-plugin: [no-unused-expressions] handle TSInstantiationExpression expression (#​7831) (31988e0)

You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin-tslint)

v6.21.0

Compare Source

🚀 Features
  • export plugin metadata (#​8331)
  • allow parserOptions.project: false (#​8339)
  • eslint-plugin: add rule prefer-find (#​8216)
  • typescript-estree: forbid duplicated accessibility modifiers (#​8257)
  • utils: improve eslint types (#​8344)
🩹 Fixes
  • ast-spec: add JSXElement type to the JSXAttribute['value'] (#​8285)
  • eslint-plugin: [no-unused-vars] don't report on types referenced in export assignment expression (#​8265)
  • eslint-plugin: [switch-exhaustiveness-check] better support for intersections, infinite types, non-union values (#​8250)
  • eslint-plugin: [consistent-type-imports] dont report on types used in export assignment expressions (#​8332)
  • eslint-plugin: [no-unnecessary-condition] handle left-hand optional with exactOptionalPropertyTypes option (#​8249)
  • eslint-plugin: [class-literal-property-style] allow getter when same key setter exists (#​8277)
  • eslint-plugin: [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before as keyword (#​8326)
  • rule-tester: fix a phantom dependency on the "semver" package (#​8260)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.20.0

Compare Source

🚀 Features
  • eslint-plugin: [member-ordering] allow easy reuse of the default ordering (#​8248)
🩹 Fixes
  • eslint-plugin: [no-useless-template-literals] incorrect bigint autofix result (#​8283)
  • eslint-plugin: [prefer-nullish-coalescing] treat any/unknown as non-nullable (#​8262)
  • eslint-plugin: [no-useless-template-literals] report Infinity & NaN (#​8295)
  • eslint-plugin: [prefer-readonly] disable checking accessors (#​8300)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.19.1

Compare Source

🩹 Fixes
  • eslint-plugin: [no-unnecessary-condition] fix false positive for type variable (#​8235)
  • type-utils: preventing isUnsafeAssignment infinite recursive calls (#​8237)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.19.0

Compare Source

🚀 Features
  • eslint-plugin: [prefer-promise-reject-errors] add rule (#​8011)
  • eslint-plugin: [no-array-delete] add new rule (#​8067)
  • eslint-plugin: [no-useless-template-literals] add fix suggestions (#​8065)
🩹 Fixes
  • eslint-plugin: [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression (#​8143)
  • eslint-plugin: [no-unnecesary-type-assertion] treat unknown/any as nullable (#​8089)
  • typescript-estree: add JSDocParsingMode enum merge for typescript/lib/tsserverlibrary (#​8193)
  • typescript-estree: disallow using as the variable keyword for for..in loops (#​7649)
  • typescript-estree: fix incorrect backwards-compat augmentation in TS 5.3 (#​8181)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.18.1

Compare Source

🩹 Fixes
  • eslint-plugin: [no-non-null-assertion] provide valid fix when member access is on next line (#​8185)
  • eslint-plugin: [no-unnecessary-condition] improve checking optional callee (#​8178)
  • eslint-plugin: [prefer-readonly] support modifiers of unions and intersections (#​8169)
  • eslint-plugin: [switch-exhaustiveness-check] fix new allowDefaultCaseForExhaustiveSwitch option (#​8176)
  • typescript-estree: fix invalid parsing error when use update expression on non-null assertion (#​8202)
  • typescript-estree: only create project service from env setting if project is enabled (#​8136)
  • utils: improve error message on typed rule with invalid parser (#​8146)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.18.0

Compare Source

🚀 Features
  • eslint-plugin: [no-var-requires, no-require-imports] allow option (#​7710)
  • typescript-estree: throw on invalid update expressions (#​7202)
  • typescript-estree: throw error when CatchClause param contains initializer (#​8183)
❤️ Thank You

You can read about our versioning strategy and releases on our website.

v6.17.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-restricted-imports] prevent crash when patterns or paths in options are empty (#​8108) (675e987)
Features
  • eslint-plugin: [no-floating-promises] flag result of .map(async) (#​7897) (5857356)
  • eslint-plugin: [switch-exhaustiveness-check] add an option to warn against a default case on an already exhaustive switch (#​7539) (6a219bd)

You can read about our versioning strategy and releases on our website.

v6.16.0

Compare Source

Bug Fixes
  • eslint-plugin: [unbound-method] exempt all non-Promise built-in statics (#​8096) (3182959)
Features
  • eslint-plugin: deprecate formatting (meta.type: layout) rules (#​8073) (04dea84)
  • eslint-plugin: deprecate no-extra-semi in favor of ESLint

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by CodeRabbit

  • Chores
    • Updated development and project dependencies (test tooling, build, linting, and spell-check) to newer stable versions for improved compatibility and stability.
    • Updated test-suite dev dependency versions used by notebook performance tests to align with the project toolchain.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

📝 Walkthrough

Walkthrough

Bumped several dependency versions in package.json: @vscode/test-cli ^0.0.8 → ^0.0.12, @vscode/test-web ^0.0.71 → ^0.0.77, cspell 9.2.1 → 9.4.0, esbuild ^0.25.1 → ^0.27.0, and lint-staged 16.2.3 → 16.2.7. Also updated @vscode/test-cli in src/test/vscode-notebook-perf/package.json from ^0.0.8 → ^0.0.12. No source code, control flow, error handling, or public/exported API signatures were changed.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately describes the main change: updating development dependencies across multiple package files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 134151f and 8b9dd0b.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (4)
package.json (3)

2656-2656: Verify esbuild version constraint—caret range allows breaking-change-prone minor upgrades.

Line 2656 shows ^0.27.0, which permits any 0.27.x or 0.28.x+ release. The past review flagged that v0.27.0 introduced breaking changes and recommended constraining to ~0.27.0 or exact 0.27.0. Although marked as addressed in prior commits, the current code still uses the caret range. If your build/test environment has fixed target Node or OS versions, verify they're compatible with any future minor release under the current constraint, or tighten to ~0.27.0.


2635-2637: VSCode test tooling pre-release updates look good.

@vscode/test-cli and @vscode/test-web are incremental pre-release bumps (0.0.8 → 0.0.12 and 0.0.71 → 0.0.77). Caret ranges on 0.0.x packages are appropriate for allowing patch-level changes. Prior TypeScript configuration concerns in the test subfolder appear resolved. No blockers here.


2651-2651: Other dev dependency updates are standard maintenance bumps.

cspell and other tooling updates (eslint, prettier, mocha, etc.) are minor/patch-level maintenance. No breaking changes detected. These are safe to merge alongside resolution of the esbuild and lint-staged concerns above.

src/test/vscode-notebook-perf/package.json (1)

33-33: Test subfolder @vscode/test-cli update aligns with root changes.

Line 33 updates to ^0.0.12, mirroring the root package.json. This is a pre-release patch bump with no known compatibility issues. Prior review confirmed TypeScript configuration is sound and @types/node is properly available.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 18, 2025
@renovate renovate bot force-pushed the renovate/dev-dependencies branch from afb79d0 to 72962ea Compare October 18, 2025 07:20
@renovate renovate bot force-pushed the renovate/dev-dependencies branch from 72962ea to 83c7bc4 Compare October 18, 2025 16:42
@codecov
Copy link

codecov bot commented Oct 18, 2025

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 18, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83c7bc4 and d32c202.

⛔ Files ignored due to path filters (1)
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
src/test/vscode-notebook-perf/package.json

[error] 1-1: npm ci failed: lockfile is out of sync and contains conflicting package versions. Several entries do not satisfy lockfile (e.g., @vscode/test-cli, @vscode/test-web, lint-staged, c8, chokidar, mocha, supports-color, @koa/router, playwright, debug, path-to-regexp, playwright-core, v8-to-istanbul, nano-spawn). Run 'npm install' to regenerate the lockfile and ensure synchronization before re-running 'npm ci'.

package.json

[error] 1-1: npm ci failed: lockfile is out of sync and contains conflicting package versions. Several entries do not satisfy lockfile (e.g., @vscode/test-cli, @vscode/test-web, lint-staged, c8, chokidar, mocha, supports-color, @koa/router, playwright, debug, path-to-regexp, playwright-core, v8-to-istanbul, nano-spawn). Run 'npm install' to regenerate the lockfile and ensure synchronization before re-running 'npm ci'.

🔇 Additional comments (2)
package.json (2)

2286-2288: @VScode test tooling bumps are reasonable.

Minor version updates for @vscode/test-cli (0.0.8 → 0.0.12) and @vscode/test-web (0.0.71 → 0.0.74) are low-risk. Ensure test suite continues to pass post-update.


2337-2337: Lint-staged patch bump is safe.

Minor patch update (16.2.3 → 16.2.4) for lint-staged carries negligible risk.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch from d32c202 to 196256c Compare October 20, 2025 17:09
@renovate renovate bot force-pushed the renovate/dev-dependencies branch 12 times, most recently from 39042b9 to 4f7069f Compare October 22, 2025 08:31
@renovate renovate bot force-pushed the renovate/dev-dependencies branch from 437310c to cb40cd1 Compare November 25, 2025 09:06
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 437310c and cb40cd1.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (3)
package.json (2)

2628-2628: Routine devDependency updates approved.

cspell 9.2.1 → 9.3.2 and lint-staged 16.2.3 → 16.2.7 are safe patch/minor updates. lint-staged is correctly placed in devDependencies only (production tool, non-runtime).

Also applies to: 2664-2664


2633-2633: Esbuild 0.27.0 contains backwards-incompatible changes—manual verification required.

Version 0.27.0 deliberately contains backwards-incompatible changes. Between the previous 0.25.1 and 0.27.0, there are several behavioral changes including:

  • Binary loader now uses Uint8Array.fromBase64, which may require specifying target when using this feature with Node unless running Node v25+
  • Operating system requirements were raised (Linux kernel 3.2+)
  • Multiple source map and build-related fixes that could affect output

The sandbox build command failed due to missing dependencies. Verify locally by running the build scripts (npm run compile-release or npm run compile-tsc + npm run esbuild-release) and confirm output remains valid for your use case.

src/test/vscode-notebook-perf/package.json (1)

33-33: Mirrors root @vscode/test-cli update.

Matches root package.json bump (^0.0.8 → ^0.0.12). Verification of test suite compilation (above) will cover both locations.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 2 times, most recently from ff08b75 to 17b92f8 Compare November 30, 2025 09:29
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ff08b75 and 17b92f8.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (2)
package.json (2)

2664-2664: ✓ lint-staged now correctly placed in devDependencies only.

Previous review flagged lint-staged appearing in both dependencies and devDependencies. Confirmed it now exists only in devDependencies (line 2664) as a pre-commit tool should be.


2612-2614: Remove this review comment—it does not apply to this repository.

This is the deepnote/vscode-deepnote repository, not the Jupyter extension. The current codebase shows no evidence of prior test suite TypeScript compilation errors. The CI workflow (.github/workflows/ci.yml) includes successful TypeScript type checking, and recent commits show only routine dependency updates with no compilation issues. The VSCode test tooling versions are present in package.json, but the stated concern about resolving prior compilation failures has no basis in this repository's history.

Likely an incorrect or invalid review comment.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 4 times, most recently from b449346 to a8ec6f2 Compare December 3, 2025 12:48
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (2)
package.json (2)

2634-2636: Test tooling updates blocked by unresolved TypeScript compilation failures.

The bumps to @vscode/test-cli (^0.0.8 → ^0.0.12) and @vscode/test-web (^0.0.71 → ^0.0.76) cannot be verified as working until the TypeScript compilation errors in src/test/vscode-notebook-perf/ are resolved. Confirm that test suite now compiles and runs successfully before merging.


2655-2655: esbuild ^0.27.0 introduces breaking changes; confirm compatibility before merge.

v0.27.0 has explicit backwards incompatibilities flagged in earlier reviews:

  • Binary loader now prefers Uint8Array.fromBase64 (affects Node.js unless target ≥ node22 or Node ≥ v25)
  • Raised OS requirements (Linux kernel ≥ 3.2, macOS ≥ 12)
  • Maintainers recommend pinning to exact version or patch-only range

Verify that your build target and CI environment requirements remain compatible, and consider changing this to ~0.27.0 or a pinned exact version instead of ^0.27.0.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b449346 and a8ec6f2.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

2686-2686: Confirm lint-staged removed from production dependencies.

Earlier reviews flagged lint-staged appearing in both dependencies and devDependencies. Verify it no longer exists under "dependencies" (lines 2502–2578) and remains only in "devDependencies".

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 2 times, most recently from a9b511e to d38c60e Compare December 4, 2025 08:53
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9b511e and d38c60e.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (4)
src/test/vscode-notebook-perf/package.json (1)

33-33: Verify test suite compiles and runs after VSCode test tooling update.

Previous reviews flagged TypeScript compilation errors in this test subfolder (missing Node.js types: Buffer, setTimeout, NodeJS namespace, atob). Confirm the test suite now compiles cleanly and passes. Verify src/test/vscode-notebook-perf/tsconfig.json includes sufficient lib configuration (e.g., "lib": ["ES2022", "DOM"]).

package.json (3)

2635-2637: Confirm VSCode test tooling compatibility after bumps.

@vscode/test-cli and @vscode/test-web updates are within pre-release ranges. Previous reviews exposed TypeScript compilation failures in the test subfolder after similar updates. Run full test suite (npm test, integration tests) to confirm no regressions.


2651-2651: Pinned cspell version is acceptable.

Patch-level bump (9.2.1 → 9.3.2) with pinned version is low-risk and safe to accept.


2687-2687: lint-staged placement is correct.

Confirmed in devDependencies only (correct location for pre-commit tooling). Patch bump (16.2.3 → 16.2.7) is safe.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch from d38c60e to c7f2b9b Compare December 4, 2025 14:18
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d38c60e and c7f2b9b.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (2)
package.json (2)

2635-2637: Verify VSCode test tooling compatibility after prior TypeScript failures.

These pre-release version bumps (0.0.8→0.0.12, 0.0.71→0.0.76) previously exposed TypeScript compilation errors in src/test/vscode-notebook-perf/src/extension.ts. Confirm the test suite now compiles without TS2688 errors.


2651-2651: cspell patch version update is acceptable.

Version 9.2.1 → 9.3.2 is a minor patch bump with no known breaking changes.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 3 times, most recently from d0d9e86 to 6931b10 Compare December 4, 2025 21:14
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
package.json (1)

2656-2656: Constrain esbuild to patch-only range.

The caret range ^0.27.0 allows minor version upgrades (0.28.0, 0.29.0, etc.). Previous review flagged that esbuild v0.27.0 introduced breaking changes and recommended locking to patch releases. Change to ~0.27.0 to prevent unexpected breakage.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d0d9e86 and 6931b10.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (2)
src/test/vscode-notebook-perf/package.json (1)

33-33: No new concerns. Prior review verified this minor version bump is compatible with the test subfolder's TypeScript configuration.

package.json (1)

2651-2651: Correct cspell version bump classification: minor, not patch.

  • cspell: 9.2.1 → 9.4.0 (dev-only, minor version bump)
  • lint-staged: 16.2.3 → 16.2.7 (dev-only pre-commit tool, patch bump)

While both are development-only tools with acceptable updates, the cspell minor version bump should be reviewed more carefully than a patch bump would warrant. Verify that the minor version upgrade does not introduce breaking changes or significant behavior shifts.

lint-staged placement is correct: it appears only in devDependencies, not in production dependencies.

"@typescript-eslint/parser": "^6.9.0",
"@vscode/dts": "^0.4.0",
"@vscode/test-cli": "^0.0.8",
"@vscode/test-cli": "^0.0.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, check if the test directory structure exists
ls -la src/test/vscode-notebook-perf/ 2>/dev/null || echo "Directory not found"

Repository: deepnote/vscode-deepnote

Length of output: 813


🏁 Script executed:

#!/bin/bash
# Check package.json for test scripts and the specific dependency
cat package.json | grep -A 5 -B 5 "@vscode/test-cli"

Repository: deepnote/vscode-deepnote

Length of output: 513


🏁 Script executed:

#!/bin/bash
# Check if the extension.ts file exists and inspect it for type issues
if [ -f "src/test/vscode-notebook-perf/src/extension.ts" ]; then
  echo "=== File exists, checking for type imports ==="
  head -30 src/test/vscode-notebook-perf/src/extension.ts
else
  echo "File not found at expected path"
  # Try to find it
  find . -name "extension.ts" -type f 2>/dev/null | head -10
fi

Repository: deepnote/vscode-deepnote

Length of output: 839


🏁 Script executed:

#!/bin/bash
# Check the structure of the test directory
find src/test/vscode-notebook-perf -type f -name "*.ts" -o -name "*.json" | head -20

Repository: deepnote/vscode-deepnote

Length of output: 495


🏁 Script executed:

#!/bin/bash
# Check the test directory's tsconfig.json
cat src/test/vscode-notebook-perf/tsconfig.json

Repository: deepnote/vscode-deepnote

Length of output: 982


🏁 Script executed:

#!/bin/bash
# Check the test directory's package.json
cat src/test/vscode-notebook-perf/package.json

Repository: deepnote/vscode-deepnote

Length of output: 1352


🏁 Script executed:

#!/bin/bash
# Check if there are any Node type references in extension.ts
grep -n "Node\|DOM" src/test/vscode-notebook-perf/src/extension.ts || echo "No Node/DOM references found in extension.ts"

Repository: deepnote/vscode-deepnote

Length of output: 107


🏁 Script executed:

#!/bin/bash
# Search for any type definition issues or Node imports in the test directory
rg "import.*from.*node" src/test/vscode-notebook-perf/ || echo "No node imports found"

Repository: deepnote/vscode-deepnote

Length of output: 89


🏁 Script executed:

#!/bin/bash
# Check if runTest.js exists and inspect it
if [ -f "src/test/vscode-notebook-perf/out/test/runTest.js" ]; then
  echo "=== runTest.js exists ==="
  cat src/test/vscode-notebook-perf/out/test/runTest.js
else
  echo "runTest.js not found in out/ directory"
  find src/test/vscode-notebook-perf -name "runTest.js" -o -name "runTest.ts" 2>/dev/null
fi

Repository: deepnote/vscode-deepnote

Length of output: 106


🏁 Script executed:

#!/bin/bash
# Check for test files in the test directory
find src/test/vscode-notebook-perf/src -name "*.ts" -type f

Repository: deepnote/vscode-deepnote

Length of output: 155


🏁 Script executed:

#!/bin/bash
# Try to compile the test extension to verify if there are actual TypeScript errors
cd src/test/vscode-notebook-perf
npm run compile 2>&1 | head -50

Repository: deepnote/vscode-deepnote

Length of output: 139


🏁 Script executed:

#!/bin/bash
# Install dependencies for the test extension
cd src/test/vscode-notebook-perf
npm install 2>&1 | tail -20

Repository: deepnote/vscode-deepnote

Length of output: 211


🏁 Script executed:

#!/bin/bash
# After install, try to compile
cd src/test/vscode-notebook-perf
npm run compile 2>&1

Repository: deepnote/vscode-deepnote

Length of output: 141


Fix TypeScript configuration to include Node type definitions.

The test extension uses NodeJS.Timeout (line 55 of src/test/vscode-notebook-perf/src/extension.ts) but the tsconfig.json only includes "ES2022" in the lib array. Add "DOM" and "Node" to the lib array in src/test/vscode-notebook-perf/tsconfig.json to resolve Node type definitions, even though @types/node is already in devDependencies.

🤖 Prompt for AI Agents
In src/test/vscode-notebook-perf/tsconfig.json (referenced from package.json
around line 2635), the TypeScript libs only include "ES2022" which leaves out
Node types used by the extension; edit that tsconfig.json to add "DOM" and
"Node" to the "lib" array (e.g., ["ES2022","DOM","Node"]) so NodeJS.Timeout and
other DOM/Node ambient types are available at compile time.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 6 times, most recently from 8fc22c4 to b1d6168 Compare December 8, 2025 08:46
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
package.json (1)

2656-2656: Constrain esbuild to patch-only range.

esbuild v0.27.0 has backwards-incompatible changes (Uint8Array.fromBase64 requires Node ≥25.0.0, Go toolchain ≥3.2 Linux/≥12 macOS). Caret range ^0.27.0 permits minor version upgrades that may introduce new breaking changes. Change to ~0.27.0 or 0.27.0 to lock updates to patch releases.

-        "esbuild": "^0.27.0",
+        "esbuild": "~0.27.0",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc22c4 and b1d6168.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • src/test/vscode-notebook-perf/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/test/vscode-notebook-perf/package.json (1 hunks)
🔇 Additional comments (3)
src/test/vscode-notebook-perf/package.json (1)

33-33: @vscode/test-cli minor version bump is acceptable.

Aligns with root package.json update and prior resolution (commit a9b511e). Correctness depends on TypeScript configuration fix in tsconfig.json (add "DOM" and "Node" to lib array if not already present).

package.json (2)

2651-2651: cspell pinned to exact version; safe.


2687-2687: lint-staged moved to devDependencies only; issue resolved.

Previously flagged as appearing in both dependencies and devDependencies. Current code shows only devDependencies placement, which is correct for a pre-commit tool.

package.json Outdated
Comment on lines 2635 to 2637
"@vscode/test-cli": "^0.0.12",
"@vscode/test-electron": "^2.3.9",
"@vscode/test-web": "^0.0.71",
"@vscode/test-web": "^0.0.76",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

find . -path "*/src/test/vscode-notebook-perf/tsconfig.json" -type f

Repository: deepnote/vscode-deepnote

Length of output: 113


🏁 Script executed:

cat ./src/test/vscode-notebook-perf/tsconfig.json

Repository: deepnote/vscode-deepnote

Length of output: 982


@vscode/test-cli and @vscode/test-web pre-release bumps require TypeScript config fix: add "DOM" and "Node" to lib array in src/test/vscode-notebook-perf/tsconfig.json.

The @vscode/test-cli (^0.0.8 → ^0.0.12) and @vscode/test-web (^0.0.71 → ^0.0.76) updates are incremental pre-release versions. However, src/test/vscode-notebook-perf/tsconfig.json currently only includes "ES2022" in its lib array and is missing "DOM" and "Node" types. Update the lib array from ["ES2022"] to ["ES2022", "DOM", "Node"] to resolve TypeScript errors in the test folder.

🤖 Prompt for AI Agents
In src/test/vscode-notebook-perf/tsconfig.json around the project's test config
(update referenced because package.json lines 2635–2637 indicate test deps
changed), the tsconfig's "lib" array currently only contains "ES2022";
TypeScript needs DOM and Node types for the updated @vscode/test-cli and
@vscode/test-web versions, so modify the "lib" array to include "DOM" and "Node"
(i.e., change ["ES2022"] to ["ES2022", "DOM", "Node"]) and save to eliminate the
type errors in that test folder.

@renovate renovate bot force-pushed the renovate/dev-dependencies branch 2 times, most recently from d93faaa to 134151f Compare December 10, 2025 08:54
@renovate renovate bot force-pushed the renovate/dev-dependencies branch from 134151f to 8b9dd0b Compare December 10, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant