Replace calls to python setup.py sdist with python -m build --sdist
#7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
changed the title
python setup.py sdistpython setup.py sdist with python -m build --sdist
…py:239:get_accelerator] Setting ds_accelerator to cuda (auto detect) [2025-02-21 15:11:28,392] [INFO] [real_accelerator.py:239:get_accelerator] Setting ds_accelerator to cuda (auto detect) Signed-off-by: Logan Adams <[email protected]>
Signed-off-by: Logan Adams <[email protected]>
Signed-off-by: Logan Adams <[email protected]>
loadams
force-pushed
the
loadams/update-deprecated-whl-commands
branch
from
c26e4aa to
66f3f68
Compare
loadams
commented
Feb 21, 2025
…tup.py sdist/bdist_wheel Signed-off-by: Logan Adams <[email protected]>
loadams
commented
Feb 21, 2025
|
I think there are a few places in docs that need to be updated as well: DeepSpeed/docs/_tutorials/ds-sequence.md Line 114 in 9d820e4 Otherwise LGTM |
Signed-off-by: Logan Adams <[email protected]>
…ub.com/microsoft/DeepSpeed into loadams/update-deprecated-whl-commands
sfc-gh-mwyatt
approved these changes
Feb 24, 2025
Signed-off-by: Logan Adams <[email protected]>
…ub.com/microsoft/DeepSpeed into loadams/update-deprecated-whl-commands
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
deepcharm
pushed a commit
to deepcharm/DeepSpeed
that referenced
this pull request
Feb 26, 2025
…t` (deepspeedai#7069) With future changes coming to pip/python/etc, we need to modify to no longer call `python setup.py ...` and replace it instead: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#should-setup-py-be-deleted  This means we need to install the build package which is added here as well. Additionally, we pass the `--sdist` flag to only build the sdist rather than the wheel as well here. --------- Signed-off-by: Logan Adams <[email protected]> Signed-off-by: Max Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With future changes coming to pip/python/etc, we need to modify to no longer call
python setup.py ...and replace it instead: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#should-setup-py-be-deletedThis means we need to install the build package which is added here as well.
Additionally, we pass the
--sdistflag to only build the sdist rather than the wheel as well here.