Default gradient_clipping to 1.0#8068
Merged
Merged
Conversation
tohtana
requested changes
Jun 23, 2026
tohtana
left a comment
tohtana
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Tunji for the update. I agree that we should enable gradient clipping by default. I left a few comments.
Change GRADIENT_CLIPPING_DEFAULT from 0. (disabled) to 1.0 so configs that omit the key clip at 1.0 by default, matching common RL/LLM training and the FSDP2 reference. Explicit "gradient_clipping": 0.0 still disables clipping. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
CPU tests cover config default and explicit 0.0 override. GPU e2e tests verify deepspeed.initialize surfaces clip norm 1.0 when omitted and 0.0 when set. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
sfc-gh-truwase
force-pushed
the
grad-clip-default-1.0
branch
from
53ecde5 to
3cd7246
Compare
Collaborator
|
@sfc-gh-truwase Thanks for the fix Tunji! Can I know why we want to hard-code gradient clipping to be 1.0? |
Collaborator
Author
This seems to be standard expectation from modeling folks that I have interacted with. It is also parity with FSDP and Megatron-LM |
tohtana
approved these changes
Jun 23, 2026
tohtana
left a comment
tohtana
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the update!
xylian86
pushed a commit
to xylian86/DeepSpeed
that referenced
this pull request
Jun 25, 2026
## Summary - Change `GRADIENT_CLIPPING_DEFAULT` from `0.` (disabled) to `1.0`. ## Motivation With the old default, configs that omit `gradient_clipping` run unclipped. Most RL/LLM training (and the FSDP2 reference) clip at `1.0`; this avoids silently-unclipped runs. Isolated into its own PR since it is a default behavior change. ## Test plan - [ ] Init without `gradient_clipping` -> effective clip norm is `1.0`. - [ ] Explicit `gradient_clipping: 0.0` still disables clipping (override respected). Made with [Cursor](https://cursor.com) --------- Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GRADIENT_CLIPPING_DEFAULTfrom0.(disabled) to1.0.Motivation
With the old default, configs that omit
gradient_clippingrun unclipped. Most RL/LLM training (and the FSDP2 reference) clip at1.0; this avoids silently-unclipped runs. Isolated into its own PR since it is a default behavior change.Test plan
gradient_clipping-> effective clip norm is1.0.gradient_clipping: 0.0still disables clipping (override respected).Made with Cursor