Route FPDT and checkpoint writer pins through accelerator pin_memory - #8257
Open
sfc-gh-truwase wants to merge 1 commit into
Open
Route FPDT and checkpoint writer pins through accelerator pin_memory#8257sfc-gh-truwase wants to merge 1 commit into
sfc-gh-truwase wants to merge 1 commit into
Conversation
Use get_accelerator().pin_memory for FPDT CPU chunks and FastFileWriter AIO buffers, with make_copy=False for empty destinations and a torch pin fallback when the CPU accelerator no-ops. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SequenceChunkand backward zero-chunk pins throughget_accelerator().pin_memory(), pinning only when the chunk is on-accelerator (avoid pin-then-discard on CPU inputs).make_copy=False, and fall back toTensor.pin_memory()when the CPU accelerator torch path no-ops so DeepNVMe can still skip bounce buffers.Test plan
pre-commit run --fileson touched paths (already run locally)DS_PIN_MEMORY_BACKEND=nativeconfirms writer buffer is pinned / managed for AIO