-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Np2 #1325
Conversation
@bgruening Some planemo tests were failing so I upped the GALAXY_BRANCH in the tests to release_24.1 (so far so good!). What I'm not sure about is the GALAXY_VERSION under deepTools_macros.xml. Can we keep this at 22 or should this be boosted as well ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all great to me. Sorry was on a conference without internet ...
The GALAXY_VERSION is some kind of upper bound. Those tools need at leat this version ... So no need for a change.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
Does the PR contain new feature?
Does the PR contain bugfix?
Does the PR contain documentation changes?
Does the PR contain changes to the galaxy wrapper?
action versions boosted
conda env for actions removed
python 3.8 support dropped, numpy v2 is mininum now, np.NAN dropped (closes Typo/Bug in heatmapper.py script #1322)
planemo galaxy branched upped to 24.1