refactor: downgrade stale _last_checkpoint log from warn! to info!#777
Conversation
warn! to info!warn! to info!
warn! to info!_last_checkpoint log from warn! to info!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 93 93
Lines 22384 22384
Branches 22384 22384
=======================================
Hits 18642 18642
Misses 2786 2786
Partials 956 956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
left a comment
There was a problem hiding this comment.
from @scovich: let's do info! by default but warn! if outside log retention duration
|
@zachschuermann Took a quick look, it will be a bit challenging to leverage the history retention window since the checkpoint hint does not include the creation timestamp, only version. To leverage the retention window, we would need to pull the last checkpoint's file metadata during log listing which requires more changes than a warning might be worth? Thinking about merging this one for now and tracking the other with an issue. #791 |
zachschuermann
left a comment
There was a problem hiding this comment.
gonna merge this for now and take up follow up in #791
What changes are proposed in this pull request?
Downgrade
warn!toinfo!when_last_checkpointis stale. Since_last_checkpointis only a hint and may frequently be out of date in a busy system, logging it as a warning is unnecessary. Clients can still see the info-level log if needed.