Skip to content

refactor: downgrade stale _last_checkpoint log from warn! to info!#777

Merged
zachschuermann merged 3 commits intodelta-io:mainfrom
sebastiantia:downgrade_warn_when_hint_is_stale
Jul 22, 2025
Merged

refactor: downgrade stale _last_checkpoint log from warn! to info!#777
zachschuermann merged 3 commits intodelta-io:mainfrom
sebastiantia:downgrade_warn_when_hint_is_stale

Conversation

@sebastiantia
Copy link
Collaborator

What changes are proposed in this pull request?

Downgrade warn! to info! when _last_checkpoint is stale. Since _last_checkpoint is only a hint and may frequently be out of date in a busy system, logging it as a warning is unnecessary. Clients can still see the info-level log if needed.

@sebastiantia sebastiantia changed the title feat: downgrade stale _last_checkpoint log from warn! to info! refactor: downgrade stale _last_checkpoint log from warn! to info! Mar 28, 2025
@sebastiantia sebastiantia changed the title refactor: downgrade stale _last_checkpoint log from warn! to info! refactor: downgrade stale _last_checkpoint log from warn! to info! Mar 28, 2025
Copy link
Member

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (245c10c) to head (0dcdf3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files          93       93           
  Lines       22384    22384           
  Branches    22384    22384           
=======================================
  Hits        18642    18642           
  Misses       2786     2786           
  Partials      956      956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking-change Public API change that could cause downstream compilation failures. Requires a major version bump. label Mar 28, 2025
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from @scovich: let's do info! by default but warn! if outside log retention duration

@sebastiantia
Copy link
Collaborator Author

@zachschuermann Took a quick look, it will be a bit challenging to leverage the history retention window since the checkpoint hint does not include the creation timestamp, only version.

To leverage the retention window, we would need to pull the last checkpoint's file metadata during log listing which requires more changes than a warning might be worth? Thinking about merging this one for now and tracking the other with an issue. #791

@zachschuermann zachschuermann removed the breaking-change Public API change that could cause downstream compilation failures. Requires a major version bump. label Jul 22, 2025
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna merge this for now and take up follow up in #791

@zachschuermann zachschuermann merged commit 829524a into delta-io:main Jul 22, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants