[Spark] Support committing multiple column changes in one txn #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctring
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The
DeltaCatalog::alterTableaccepts a list of table changes. However, we are currently committing the column changes in separate transactions. This PR does the following refactoring:DeltaChangeColumnSpecas arguments toAlterTableChangeColumnDeltaCommandso that we can pass multiple changes and commit them in one transaction.DeltaCatalog::alterTableto collect the column changes intoDeltaChangeColumnSpecDeltaCatalog::alterTablepreviously has a single syncIdentity variable for all table changes to denote whether to run sync identity or not. This PR fixes that and record the sync identity parameter separately for each column.How was this patch tested?
Existing unit tests
Does this PR introduce any user-facing changes?
No