[WIP][Kernel][DefaultEngine] Refactor the Default Engine to not use Hadoop directly, instead provide a generic IO interface #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Hadoop APIs are used throughout the default Engine. This is a problem for connectors that don't want to depend on the Hadoop. This is an attempt to separate out the I/O related functionality into an interface (
FileIO) and provide Hadoop based implementation ofFileIOfor connector that want to use the default engine with Hadoop. For other connectors that don't want Hadoop, can provide their own implementation of theFileIOto the default engine.WIP: parquet write side work is remaining.
How was this patch tested?
Existing tests. Need to add code test to not use the Hadoop directly.