Uniform: Fix microsecond conversion for timestamp/ntz partition value #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
force-pushed
the
fix-iceberg-micro-conversion
branch
from
2cbe206 to
6717552
Compare
| @@ -83,7 +83,7 @@ abstract class UniFormE2EIcebergSuiteBase extends UniFormE2ETest { | |||
| s"where ${partitionColumnName}=${partitionColumnsAndValues._2}" | |||
| // Verify against Delta read and Iceberg read | |||
| checkAnswer(spark.sql(verificationQuery), Seq(Row(123))) | |||
| checkAnswer(createReaderSparkSession.sql(verificationQuery), Seq(Row(123))) | |||
There was a problem hiding this comment.
it's important to go through the read function, for some reason when I go through createReaderSparkSession directly that doesn't actually use the Iceberg spark session even though we are overriding it correctly.
amogh-jahagirdar
force-pushed
the
fix-iceberg-micro-conversion
branch
from
6717552 to
3755e1a
Compare
lzlfred
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
When converting timestamp partition values from Delta to Iceberg, currently we're doing the microsecond conversion incorectly. This leads to every conversion just returning the Unix epoch timestamp.
In the current approach we're using some utilities from Iceberg, such as DateTimeUtil.microsFromInstant which already have implemented this logic correctly.
There were unit tests that should've caught this earlier by testing the Iceberg spark session as a reader, but they were passing just because the wrong read method was used. This PR fixes that as well.
How was this patch tested?
I fixed existing unit tests since they should've caught this.
Does this PR introduce any user-facing changes?