[Kernel] Fix config passed to the column mapping mode change validation method #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
force-pushed
the
fixCMValidation
branch
from
f78d36b to
c191429
Compare
vkorukanti
force-pushed
the
fixCMValidation
branch
from
c191429 to
234face
Compare
vkorukanti
changed the title
allisonport-db
approved these changes
Feb 28, 2025
| @@ -1210,6 +1210,40 @@ class DeltaTableWritesSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBa | |||
| } | |||
| } | |||
|
|
|||
| test("update table properties on a column mapping enabled table") { | |||
There was a problem hiding this comment.
this wasn't super intuitive to me at first to understand the issue, can you confirm that I understand correctly?
- before, we were passing only the
newPropertiesas the new config - this means we would identify the
newMappingMode=noneand then fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
ColumnMapping.verifyColumnMappingChangetakes just the new properties as the argument for the new configuration. This is incorrect, as the method looks for the CM mode based on the new complete config.Also missing the test coverage for this. Add a new test.