forked from microsoft/winget-pkgs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
first draft for auto-approval specification
- Loading branch information
Showing
2 changed files
with
122 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --- | ||
| author: <first-name> <last-name> <github-id>/<email> | ||
| created on: <yyyy-mm-dd> | ||
| last updated: <yyyy-mm-dd> | ||
| issue id: <github issue id> | ||
| --- | ||
|
|
||
| # Spec Title | ||
|
|
||
| [comment]: # Link to issue: "For [#1](https://github.com/microsoft/winget-pkgs/issues/1)" | ||
|
|
||
| ## Abstract | ||
|
|
||
| [comment]: # Outline what this spec describes | ||
| This specification defines criteria for auto-approval of PRs for a subset of packages in an allow list. These auto-approvals will be limited to packages in the allow list only when a limited set of properties have been modified. These would include package version, and package URL (filtered by logic for installer URLs on the same domain and path). | ||
|
|
||
| ## Inspiration | ||
|
|
||
| [comment]: # What were the drivers/inspiration behind the creation of this spec. | ||
| Several packages have rich metadata and when new versions are added, the only changes are the installer portion of the URL and the package version. | ||
|
|
||
| ## Solution Design | ||
|
|
||
| [comment]: # Outline the design of the solution. Feel free to include ASCII-art diagrams, etc. | ||
|
|
||
| ## UI/UX Design | ||
|
|
||
| [comment]: # What will this fix/feature look like? How will it affect the end user? | ||
|
|
||
| ## Capabilities | ||
|
|
||
| [comment]: # Discuss how the proposed fixes/features impact the following key considerations: | ||
|
|
||
| ### Accessibility | ||
|
|
||
| [comment]: # How will the proposed change impact accessibility for users of screen readers, assistive input devices, etc. | ||
|
|
||
| ### Security | ||
|
|
||
| [comment]: # How will the proposed change impact security? | ||
|
|
||
| ### Reliability | ||
|
|
||
| [comment]: # Will the proposed change improve reliability? If not, why make the change? | ||
|
|
||
| ### Compatibility | ||
|
|
||
| [comment]: # Will the proposed change break existing code/behaviors? If so, how, and is the breaking change "worth it"? | ||
|
|
||
| ### Performance, Power, and Efficiency | ||
|
|
||
| ## Potential Issues | ||
|
|
||
| [comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted. | ||
|
|
||
| ## Future considerations | ||
|
|
||
| [comment]: # What are some of the things that the fixes/features might unlock in the future? Does the implementation of this spec enable scenarios? | ||
|
|
||
| ## Resources | ||
|
|
||
| [comment]: # Be sure to add links to references, resources, footnotes, etc. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| --- | ||
| author: <first-name> <last-name> <github-id>/<email> | ||
| created on: <yyyy-mm-dd> | ||
| last updated: <yyyy-mm-dd> | ||
| issue id: <github issue id> | ||
| --- | ||
|
|
||
| # Spec Title | ||
|
|
||
| [comment]: # Link to issue: "For [#1](https://github.com/microsoft/winget-pkgs/issues/1)" | ||
|
|
||
| ## Abstract | ||
|
|
||
| [comment]: # Outline what this spec describes | ||
|
|
||
| ## Inspiration | ||
|
|
||
| [comment]: # What were the drivers/inspiration behind the creation of this spec. | ||
|
|
||
| ## Solution Design | ||
|
|
||
| [comment]: # Outline the design of the solution. Feel free to include ASCII-art diagrams, etc. | ||
|
|
||
| ## UI/UX Design | ||
|
|
||
| [comment]: # What will this fix/feature look like? How will it affect the end user? | ||
|
|
||
| ## Capabilities | ||
|
|
||
| [comment]: # Discuss how the proposed fixes/features impact the following key considerations: | ||
|
|
||
| ### Accessibility | ||
|
|
||
| [comment]: # How will the proposed change impact accessibility for users of screen readers, assistive input devices, etc. | ||
|
|
||
| ### Security | ||
|
|
||
| [comment]: # How will the proposed change impact security? | ||
|
|
||
| ### Reliability | ||
|
|
||
| [comment]: # Will the proposed change improve reliability? If not, why make the change? | ||
|
|
||
| ### Compatibility | ||
|
|
||
| [comment]: # Will the proposed change break existing code/behaviors? If so, how, and is the breaking change "worth it"? | ||
|
|
||
| ### Performance, Power, and Efficiency | ||
|
|
||
| ## Potential Issues | ||
|
|
||
| [comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted. | ||
|
|
||
| ## Future considerations | ||
|
|
||
| [comment]: # What are some of the things that the fixes/features might unlock in the future? Does the implementation of this spec enable scenarios? | ||
|
|
||
| ## Resources | ||
|
|
||
| [comment]: # Be sure to add links to references, resources, footnotes, etc. |