Fix UnboundLocalError: focal_length_y not initialized for SIMPLE_RADIAL#16
Open
Ryanshuai wants to merge 1 commit intodenghilbert:mainfrom
Open
Fix UnboundLocalError: focal_length_y not initialized for SIMPLE_RADIAL#16Ryanshuai wants to merge 1 commit intodenghilbert:mainfrom
Ryanshuai wants to merge 1 commit intodenghilbert:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Training fails with
UnboundLocalError: local variable 'focal_length_y' referenced before assignmentwhen using SIMPLE_RADIAL camera model from COLMAP.Solution
Initialize
focal_length_y = Nonebefore camera model branches inreadColmapCameras().The SIMPLE_RADIAL model uses a single focal length and doesn't define
focal_length_y, but the code later references it at line 207. The existing else branch correctly handles this by usingfocal_length_xas a fallback whenfocal_length_yis None.Testing
Tested with COLMAP SIMPLE_RADIAL camera model, training now runs successfully.