[WIP] more general indexing for KnetArray#229
Open
CarloLucibello wants to merge 2 commits intodenizyuret:masterfrom
Open
[WIP] more general indexing for KnetArray#229CarloLucibello wants to merge 2 commits intodenizyuret:masterfrom
CarloLucibello wants to merge 2 commits intodenizyuret:masterfrom
Conversation
Owner
|
Let's performance check these implementations before releasing them. At least let's make sure that they are faster than a copy-to-cpu, index, copy-to-gpu round-trip solution. |
Collaborator
Author
will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add general
getindexandsetindex!fallbacks to deal with cases like these, currently giving errors:It uses some machinery from Base to fallback to indexing with a vector of linear indexes.
Most credits go to @carlobaldassi
Still, have to test properly and to drop scalar dimensions in reshape.