feat(unstable/npm): initial type checking of npm specifiers #16332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Investigating why I can't provide tsc that a source file is cjs... might need to use a document registry :(
bartlomieju
reviewed
Oct 20, 2022
Comment on lines
+858
to
+862
| if let Some(npm_resolver) = &snapshot.maybe_npm_resolver { | ||
| // show diagnostics for npm package references that aren't cached | ||
| if npm_resolver | ||
| .resolve_package_folder_from_deno_module(&pkg_ref.req) | ||
| .is_err() |
There was a problem hiding this comment.
That this handle situation when user has --node-modules-dir flag specified?
There was a problem hiding this comment.
Nope. That's not supported at the moment because there's no way to provide that to the lsp at the moment (see second point in pr description). Edit: opened an issue.
This was referenced Oct 20, 2022
This was referenced Oct 20, 2022
bartlomieju
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for type checking npm specifiers.
node_modulesfolder and prefer to use that? Edit: Opened lsp: should work with local node_modules directory #16373--remoteflag indeno check --remote main.tsshould probably be renameddeno check --all main.tsto align withdeno run --check=all main.ts.deno run --check/deno checkdoesn't type check npm packages by default in these changes and--remotedoesn't really make sense for that given we have a distinction between "remote" and npm packages elsewhere (ex.--no-remoteand--no-npm) Edit: Opened Consider renamingdeno check --remoteto--all#16374/// <reference types="npm:@types/node" />directive must be added to the code. This is necessary because there may be scenarios where people want to use npm modules without node types.todo: