experiment: faster wasm streaming in Rust #21323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Nov 24, 2023
ext/fetch/wasm_streaming.rs
Outdated
| } | ||
|
|
||
| /* XXX: crashes here if module compilation fails */ | ||
| wasm_streaming.finish(); |
There was a problem hiding this comment.
Addressing this in WIP feature:
mmastrac
reviewed
Nov 24, 2023
| value: v8::Local<v8::Value>, | ||
| mut wasm_streaming: v8::WasmStreaming, | ||
| ) { | ||
| let (url, rid) = match compile_response(scope, value) { |
There was a problem hiding this comment.
I think we should make a call into JS here to do a branding check and extract the stream RID, as this could in theory be created w/a Response that is not sourced from fetch.
There was a problem hiding this comment.
It would be mean having two wasm streaming callbacks. One in JS doing the brand check and one for streaming in Rust. I don't think the brand check is actually enforced by wpt.
|
I like this approach, well done. Let me try to get the task spawner experiment working and we can see how they work together. |
|
Closing because it's stale and we're tackling WASM imports. Feel free to reopen if you want to rebase and try to land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref denoland/deno_core#349