fix(lint): linting package with .css file should raise no errors #26695
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently failing with There are two issues here that I want to fix:
|
bartlomieju
commented
Nov 4, 2024
Comment on lines
+296
to
+299
| eprintln!("paths {:#?}", paths); | ||
| let mut futures = Vec::with_capacity(2); | ||
| if linter.has_package_rules() { | ||
| // Package rules are only in effect if user didn't explicitly specify paths on the command line | ||
| if paths.is_empty() && linter.has_package_rules() { |
There was a problem hiding this comment.
This bit seems broken - whether we invoke deno lint or deno lint main.ts in a directory that has deno.json, the paths contains main.ts. We were unconditionally running the "package rules" lints as long as the deno.json contains "publish config". Changing this conditional effectively breaks package lints. I think this whole bit should be rewritten to account for the fact that we're running lint for a whole dir or a certain file.
bartlomieju
commented
Nov 4, 2024
| @@ -276,7 +280,9 @@ impl ModuleGraphCreator { | |||
| loader: None, | |||
| }) | |||
| .await?; | |||
| self.graph_valid(&graph)?; | |||
| let r = self.graph_valid(&graph); | |||
There was a problem hiding this comment.
This call should filter out "unsupported media type" errors when graph is used for linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26308