fix(node/fs): add a createReadStream method to the FileHandle class #27591
+67
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
kt3k
changed the title
kt3k
reviewed
Jan 14, 2025
| createReadStream(options?: CreateReadStreamOptions): ReadStream { | ||
| assertNotClosed(this, createReadStream.name); | ||
| const opts = options as Omit<CreateReadStreamOptions, "encoding">; | ||
| return createReadStream(this.#path, opts); |
There was a problem hiding this comment.
This opens another file object. We need to reuse #rid of this file handle.
Please follow what Node.js does here https://github.com/nodejs/node/blob/5770972dc6c0458af5458b8056b16d70905ea9d8/lib/internal/fs/promises.js#L361-L364
kt3k
reviewed
Jan 14, 2025
| chmod(mode: Mode): Promise<void> { | ||
| assertNotClosed(this, promises.chmod.name); | ||
| return promises.chmod(this.#path, mode); | ||
| } | ||
|
|
||
| createReadStream(options?: CreateReadStreamOptions): ReadStream { | ||
| assertNotClosed(this, createReadStream.name); |
There was a problem hiding this comment.
This assertion doesn't exist in Node.js https://github.com/nodejs/node/blob/5770972dc6c0458af5458b8056b16d70905ea9d8/lib/internal/fs/promises.js#L361-L364
nkaradzhov
force-pushed
the
feat_createreadstream_to_filehandle
branch
from
f2859fe to
d7e0037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the createReadStream method to the FileHandle class in node compat as part of #25554