fix(ext/node): reimplement setImmediate API

Cargo.toml

@@ -533,3 +533,6 @@ opt-level = 3
 opt-level = 3
 [profile.release.package.deno_npm_cache]
 opt-level = 3
+
+[patch.crates-io]
+deno_core = { path = "../deno_core/core" }

cli/lib/util/result.rs

@@ -25,7 +25,7 @@ impl<T> InfallibleResultExt<T> for Result<T, Infallible> {
 
 pub fn js_error_downcast_ref(
   err: &AnyError,
-) -> Option<&deno_runtime::deno_core::error::JsError> {
+) -> Option<&Box<deno_runtime::deno_core::error::JsError>> {
   any_and_jserrorbox_downcast_ref(err).or_else(|| {
     err
       .downcast_ref::<CoreError>()

cli/lib/worker.rs

@@ -816,32 +816,29 @@ impl LibMainWorker {
   }
 
   #[inline]
-  #[allow(clippy::result_large_err)]
-  pub fn dispatch_load_event(&mut self) -> Result<(), JsError> {
+  pub fn dispatch_load_event(&mut self) -> Result<(), Box<JsError>> {
     self.worker.dispatch_load_event()
   }
 
   #[inline]
-  #[allow(clippy::result_large_err)]
-  pub fn dispatch_beforeunload_event(&mut self) -> Result<bool, JsError> {
+  pub fn dispatch_beforeunload_event(&mut self) -> Result<bool, Box<JsError>> {
     self.worker.dispatch_beforeunload_event()
   }
 
   #[inline]
-  #[allow(clippy::result_large_err)]
-  pub fn dispatch_process_beforeexit_event(&mut self) -> Result<bool, JsError> {
+  pub fn dispatch_process_beforeexit_event(
+    &mut self,
+  ) -> Result<bool, Box<JsError>> {
     self.worker.dispatch_process_beforeexit_event()
   }
 
   #[inline]
-  #[allow(clippy::result_large_err)]
-  pub fn dispatch_unload_event(&mut self) -> Result<(), JsError> {
+  pub fn dispatch_unload_event(&mut self) -> Result<(), Box<JsError>> {
     self.worker.dispatch_unload_event()
   }
 
   #[inline]
-  #[allow(clippy::result_large_err)]
-  pub fn dispatch_process_exit_event(&mut self) -> Result<(), JsError> {
+  pub fn dispatch_process_exit_event(&mut self) -> Result<(), Box<JsError>> {
     self.worker.dispatch_process_exit_event()
   }
 

cli/tools/bench/mod.rs

@@ -168,10 +168,7 @@ async fn bench_specifier(
     Ok(()) => Ok(()),
     Err(CreateCustomWorkerError::Core(error)) => match error.into_kind() {
       CoreErrorKind::Js(error) => {
-        sender.send(BenchEvent::UncaughtError(
-          specifier.to_string(),
-          Box::new(error),
-        ))?;
+        sender.send(BenchEvent::UncaughtError(specifier.to_string(), error))?;
         Ok(())
       }
       error => Err(error.into_box().into()),

cli/tools/test/mod.rs

@@ -688,7 +688,7 @@ async fn configure_main_worker(
       Ok(()) => Ok(()),
       Err(CoreErrorKind::Js(err)) => send_test_event(
         &op_state,
-        TestEvent::UncaughtError(specifier.to_string(), Box::new(err)),
+        TestEvent::UncaughtError(specifier.to_string(), err),
       )
       .map_err(|e| CoreErrorKind::JsBox(JsErrorBox::from_err(e)).into_box()),
       Err(err) => Err(err.into_box()),
@@ -742,7 +742,7 @@ pub async fn test_specifier(
       CoreErrorKind::Js(err) => {
         send_test_event(
           &worker.js_runtime.op_state(),
-          TestEvent::UncaughtError(specifier.to_string(), Box::new(err)),
+          TestEvent::UncaughtError(specifier.to_string(), err),
         )?;
         Ok(())
       }
@@ -1059,7 +1059,7 @@ async fn run_tests_for_worker_inner(
         CoreErrorKind::Js(js_error) => {
           send_test_event(
             &state_rc,
-            TestEvent::UncaughtError(specifier.to_string(), Box::new(js_error)),
+            TestEvent::UncaughtError(specifier.to_string(), js_error),
           )?;
           fail_fast_tracker.add_failure();
           send_test_event(

cli/tsc/mod.rs

@@ -1296,15 +1296,14 @@ fn op_respond_inner(state: &mut OpState, args: RespondArgs) {
   state.maybe_response = Some(args);
 }
 
-#[allow(clippy::large_enum_variant)]
 #[derive(Debug, Error, deno_error::JsError)]
 pub enum ExecError {
   #[class(generic)]
   #[error("The response for the exec request was not set.")]
   ResponseNotSet,
   #[class(inherit)]
   #[error(transparent)]
-  Js(deno_core::error::JsError),
+  Js(Box<deno_core::error::JsError>),
 }
 
 #[derive(Clone)]

cli/worker.rs

@@ -276,12 +276,11 @@ impl CliMainWorker {
     Ok(Some(coverage_collector))
   }
 
-  #[allow(clippy::result_large_err)]
   pub fn execute_script_static(
     &mut self,
     name: &'static str,
     source_code: &'static str,
-  ) -> Result<v8::Global<v8::Value>, JsError> {
+  ) -> Result<v8::Global<v8::Value>, Box<JsError>> {
     self.worker.js_runtime().execute_script(name, source_code)
   }
 }