Skip to content

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Feb 27, 2025

@dsherret dsherret marked this pull request as ready for review April 8, 2025 17:22
@dsherret dsherret requested a review from nathanwhit April 8, 2025 17:22
self.program_ref().compute_is_script()
} else {
matches!(self.program_ref(), ProgramRef::Script(_))
}
Copy link
Member Author

@dsherret dsherret Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight perf improvement for non-typescript sources.

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 1c8c2ba into denoland:main Apr 8, 2025
2 checks passed
@dsherret dsherret deleted the tests_compute_script branch April 8, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants