feat: support for case-insensitive matches#34
Merged
crowlKats merged 10 commits intodenoland:mainfrom Jul 31, 2024
Merged
Conversation
Member
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
Please make the case flag an options bag
Member
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
generate_matcher is going to significantly suffer here. It will be unable to generate matchers for case insensitive parts
Member
Author
thats a problem, but i dont think there is much we can do (I'd be happily proven wrong) |
|
@crowlKats @lucacasonato - Any chance that this might land in Deno? According to https://developer.mozilla.org/en-US/docs/Web/API/URLPattern#browser_compatibility Deno has everything else implemented according to the spec except for the |
This was referenced Nov 1, 2023
# Conflicts: # src/component.rs # src/quirks.rs
crowlKats
commented
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements whatwg/urlpattern#168
Closes #12