Skip to content

Commit

Permalink
disable pointer compression (#1593)
Browse files Browse the repository at this point in the history
  • Loading branch information
devsnek committed Aug 28, 2024
1 parent df6b809 commit 48800f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 2 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ default_args = {
v8_use_external_startup_data = false
v8_use_snapshot = true

v8_enable_pointer_compression = false

# This flag speeds up the performance of fork/execve on Linux systems for
# embedders which use it (like Node.js). It works by marking the pages that
# V8 allocates as MADV_DONTFORK. Without MADV_DONTFORK, the Linux kernel
Expand Down
8 changes: 0 additions & 8 deletions src/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3367,14 +3367,6 @@ void v8__HeapProfiler__TakeHeapSnapshot(v8::Isolate* isolate,
const_cast<v8::HeapSnapshot*>(snapshot)->Delete();
}

// This is necessary for v8__internal__GetIsolateFromHeapObject() to be
// reliable enough for our purposes.
#if UINTPTR_MAX == 0xffffffffffffffff && \
!(defined V8_SHARED_RO_HEAP or defined V8_COMPRESS_POINTERS)
#error V8 must be built with either the 'v8_enable_pointer_compression' or \
'v8_enable_shared_ro_heap' feature enabled.
#endif

v8::Isolate* v8__internal__GetIsolateFromHeapObject(const v8::Data& data) {
namespace i = v8::internal;
i::Tagged<i::Object> object(reinterpret_cast<const i::Address&>(data));
Expand Down

0 comments on commit 48800f8

Please sign in to comment.