-
Notifications
You must be signed in to change notification settings - Fork 653
feat(testing/unstable): add it.todo
test.todo
and describe.todo
API
#6712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have policy to add new features as unstable APIs first. https://github.com/denoland/std/blob/main/.github/CONTRIBUTING.md#suggesting-a-new-feature Can you create a new file |
Sure, I'll update. |
@kt3k It seems there has a little problem, the import { describe } from "@std/testing/bdd"
import "@std/testing/unstable-bdd"
// then we can call `describe.todo`
describe.todo(/* function params */); |
How about re-exporting all bdd APIs from import { describe } from "@std/testing/unstable-bdd"
// then we can call `describe.todo`
describe.todo(/* function params */); |
Ohh, that's right |
It seems not working, according to the ci, this will throw an error:
|
Or rename the |
it.todo
test.todo
and describe.todo
APIit.todo
test.todo
and describe.todo
API
@eryue0220 I resolved the type errors in |
Sure, because the params has a bit difference, one ( |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6712 +/- ##
==========================================
- Coverage 94.15% 94.11% -0.04%
==========================================
Files 587 588 +1
Lines 42467 42597 +130
Branches 6702 6702
==========================================
+ Hits 39984 40091 +107
- Misses 2434 2457 +23
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in review!
LGTM!
This pr is to solve #5711 to add new
todo
api for test suite methods.