Skip to content

fix(http): allow HEAD method in file-server #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(http): allow HEAD method in file-server #6752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d322f56
fix(http): allow HEAD method in file-server
krugerLucas Jul 5, 2025
a6cb2fa
Merge branch 'main' into fix/allow-head-method-in-file-server
krugerLucas Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http/file_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ export async function serveDir(
req: Request,
opts: ServeDirOptions = {},
): Promise<Response> {
if (req.method !== METHOD.Get) {
if (req.method !== METHOD.Get && req.method !== METHOD.Head) {
return createStandardResponse(STATUS_CODE.MethodNotAllowed);
}

Expand Down
24 changes: 24 additions & 0 deletions http/file_server_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,6 +1152,30 @@ Deno.test(async function serveFileHeadRequest() {
assertEquals(res.headers.get("content-length"), "10034");
});

Deno.test(async function serveDirHeadRequest() {
const req = new Request("http://localhost/test_file.txt", {
method: "HEAD",
});
const res = await serveDir(req, serveDirOptions);
assert(!res.body);
assertEquals(res.status, 200);
assertEquals(res.statusText, "OK");
assertEquals(res.headers.get("content-type"), "text/plain; charset=UTF-8");
assertEquals(res.headers.get("content-length"), "10034");
});

Deno.test(async function serveDirHeadRequestForDirectoryWithIndex() {
const req = new Request("http://localhost/subdir-with-index/", {
method: "HEAD",
});
const res = await serveDir(req, serveDirOptions);
assert(!res.body);
assertEquals(res.status, 200);
assertEquals(res.statusText, "OK");
assertEquals(res.headers.get("content-type"), "text/html; charset=UTF-8");
assert(res.headers.has("content-length"));
});

Deno.test("(unstable) serveDir() serves files without the need of html extension when cleanUrls=true", async () => {
const req = new Request("http://localhost/hello");
const res = await unstableServeDir(req, {
Expand Down
Loading