feat(net/unstable): add matchSubnets on @std/net #6786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Octo8080X
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6786 +/- ##
==========================================
+ Coverage 94.19% 94.21% +0.02%
==========================================
Files 590 590
Lines 42649 42811 +162
Branches 6726 6784 +58
==========================================
+ Hits 40173 40336 +163
+ Misses 2427 2425 -2
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would be great if there were a near 100% test coverage for new apis. |
Octo8080X
force-pushed
the
feature/update_ip_utils
branch
from
aa5a63e to
cd3ba91
Compare
|
@timreichen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target #6722
This PR adds the matchSubnets(addr: string, subnetOrIps: string[]): boolean functions