Skip to content

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 9, 2025

Closes #6787

@dsherret dsherret requested a review from kt3k as a code owner August 9, 2025 14:49
@github-actions github-actions bot added the fs label Aug 9, 2025
@dsherret dsherret changed the title fix(fs/expand-glob): match non-glob path segments containing escaped glob chars fix(fs): expandGlob/expandGlobSync - match non-glob path segments containing escaped glob chars Aug 9, 2025
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (c3331d5) to head (71af5c0).

Files with missing lines Patch % Lines
fs/expand_glob.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
- Coverage   94.14%   94.14%   -0.01%     
==========================================
  Files         589      589              
  Lines       42540    42544       +4     
  Branches     6717     6716       -1     
==========================================
+ Hits        40050    40052       +2     
- Misses       2440     2443       +3     
+ Partials       50       49       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expandGlob/expandGlobSync does not handle escaped paths well
2 participants