fix(shortcut): Correct isActive logic when both preset_mode and percentage are set #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this config:
And no matter which shortcut I click, they are all always marked as active, because the
preset_modeis always the same. In this simple example, I could of course remove thepreset_mode, but I also have other shortcuts and differentpreset_modes.This change improves the logic that determines whether the purifier is active by taking into account whether
preset_modeand/orpercentageare explicitly set in the configuration.✅ Previous Behavior
The isActive state was determined by checking if either percentage or preset_mode matched their corresponding attribute values. This could lead to incorrect results when both options were configured.
🔄 Updated Behavior
Now, isActive is set to true only if:
percentagematches andpreset_modeis not set, orpreset_modematches andpercentageis not set, or