[Feature] Goal API 작성 #27 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egg528
reviewed
Dec 15, 2023
| return ResponseEntity.ok(response) | ||
| } | ||
|
|
||
| @GetMapping("/{goal_id}") |
There was a problem hiding this comment.
pathVariable도 카멜 케이스로 통일해도 좋을 것 같습니다~!
egg528
reviewed
Dec 15, 2023
| } | ||
|
|
||
| @DeleteMapping | ||
| fun delete( |
There was a problem hiding this comment.
delete의 경우 http status noContent로 반환해도 좋을 것 같습니다!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
명세에 맞춰 Goal 관련 비즈니스 로직을 작성하고 API를 구현하겠습니다. -> 명세 #27
1. 구현 사항
String을 날짜 포멧에 맞는 숫자들로 변경하고, 고정된 Day 값을 관리할 객체가 필요할 것 같아 구현했습니다.
물론 DB에 직접 null을 저장하는 것은 좋지 않다고 생각되어, null의 경우 빈 문자열
""로 값이 설정되도록 했습니다.