fuzzamoto-ir: implement BuildPayToBareMulti#129
Open
brunoerg wants to merge 1 commit intodergoegge:masterfrom
Open
fuzzamoto-ir: implement BuildPayToBareMulti#129brunoerg wants to merge 1 commit intodergoegge:masterfrom
brunoerg wants to merge 1 commit intodergoegge:masterfrom
Conversation
brunoerg
force-pushed
the
2026-02-bare-multisig
branch
from
d0674f0 to
632cc61
Compare
brunoerg
force-pushed
the
2026-02-bare-multisig
branch
from
632cc61 to
1ad8f95
Compare
dergoegge
reviewed
Mar 11, 2026
| let mut sig_script_builder = | ||
| ScriptBuf::builder().push_opcode(bitcoin::opcodes::OP_0); | ||
|
|
||
| for sk_bytes in private_keys.iter().take(*required as usize) { |
Owner
There was a problem hiding this comment.
Will this ever result in a p2ms that has less signatures than required?
Contributor
Author
There was a problem hiding this comment.
No, because of let required_clamped = (*required).min(n).max(1); which is the used required here. So it can never produce fewer signatures than required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.