Skip to content

Minor suggestion to add log on scans #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor suggestion to add log on scans #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...gnin/spring/data/dynamodb/repository/query/DynamoDBEntityWithHashAndRangeKeyCriteria.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@
*/
package org.socialsignin.spring.data.dynamodb.repository.query;

import static java.util.stream.Collectors.joining;

import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel;
import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBQueryExpression;
import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBScanExpression;
import com.amazonaws.services.dynamodbv2.model.ComparisonOperator;
import com.amazonaws.services.dynamodbv2.model.Condition;
import com.amazonaws.services.dynamodbv2.model.QueryRequest;
import com.amazonaws.services.dynamodbv2.model.Select;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.socialsignin.spring.data.dynamodb.core.DynamoDBOperations;
import org.socialsignin.spring.data.dynamodb.query.CountByHashAndRangeKeyQuery;
import org.socialsignin.spring.data.dynamodb.query.MultipleEntityQueryExpressionQuery;
Expand Down Expand Up @@ -50,6 +54,8 @@
*/
public class DynamoDBEntityWithHashAndRangeKeyCriteria<T, ID> extends AbstractDynamoDBQueryCriteria<T, ID> {

private static final Logger LOGGER = LoggerFactory.getLogger(DynamoDBEntityWithHashAndRangeKeyCriteria.class);

private Object rangeKeyAttributeValue;
private Object rangeKeyPropertyValue;
private String rangeKeyPropertyName;
Expand Down Expand Up @@ -359,6 +365,10 @@ public DynamoDBScanExpression buildScanExpression() {
scanExpression.addFilterCondition(conditionEntry.getKey(), condition);
}
}

LOGGER.warn("Executing Scan for table '{}' when querying by <{}>", entityInformation.getDynamoDBTableName(),
attributeConditions.keySet().stream().collect(joining(", ")));

return scanExpression;
}

Expand Down
10 changes: 10 additions & 0 deletions ...alsignin/spring/data/dynamodb/repository/query/DynamoDBEntityWithHashKeyOnlyCriteria.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,16 @@
*/
package org.socialsignin.spring.data.dynamodb.repository.query;

import static java.util.stream.Collectors.joining;

import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel;
import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBScanExpression;
import com.amazonaws.services.dynamodbv2.model.ComparisonOperator;
import com.amazonaws.services.dynamodbv2.model.Condition;
import com.amazonaws.services.dynamodbv2.model.QueryRequest;
import com.amazonaws.services.dynamodbv2.model.Select;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.socialsignin.spring.data.dynamodb.core.DynamoDBOperations;
import org.socialsignin.spring.data.dynamodb.query.CountByHashKeyQuery;
import org.socialsignin.spring.data.dynamodb.query.MultipleEntityQueryRequestQuery;
Expand All @@ -40,6 +44,8 @@
*/
public class DynamoDBEntityWithHashKeyOnlyCriteria<T, ID> extends AbstractDynamoDBQueryCriteria<T, ID> {

private static final Logger LOGGER = LoggerFactory.getLogger(DynamoDBEntityWithHashKeyOnlyCriteria.class);

private DynamoDBEntityInformation<T, ID> entityInformation;

public DynamoDBEntityWithHashKeyOnlyCriteria(DynamoDBEntityInformation<T, ID> entityInformation,
Expand Down Expand Up @@ -117,6 +123,10 @@ public DynamoDBScanExpression buildScanExpression() {
scanExpression.setProjectionExpression(projection.get());
}
limit.ifPresent(scanExpression::setLimit);

LOGGER.warn("Executing Scan for table '{}' when querying by <{}>", entityInformation.getDynamoDBTableName(),
attributeConditions.keySet().stream().collect(joining(", ")));

return scanExpression;
}

Expand Down