Skip to content

Docker images#25

Open
nils-wisiol wants to merge 9 commits intomainfrom
docker-images
Open

Docker images#25
nils-wisiol wants to merge 9 commits intomainfrom
docker-images

Conversation

@nils-wisiol
Copy link
Copy Markdown
Contributor

@nils-wisiol nils-wisiol commented Jun 17, 2023

No description provided.

Cub0n and others added 6 commits January 14, 2023 20:19
@Cub0n
Building and publishing dns-desec docker image
c7dd8da
@Cub0n
Create Dockerfile
3ae9cb6
@Cub0n
Base image and version
cbb73ff 
* Change base image architecture and version
* Remove version from certbot-dns-desec
@Cub0n
Bump to certbot 2.2.0
af1613c 
* Based on Certbot 2.2.0 now
* Builds certbot-dns-desec Docker from local sources
@Cub0n
Bump certbot; Link images
1dff01c 
* Bump to certbot 2.2.0
* Link images together under "latest" tag
@nils-wisiol
Bump to certbot 2.6
036ab31
@nils-wisiol nils-wisiol mentioned this pull request Jun 17, 2023
Closed
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:25 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:25 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:25 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:25 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 17, 2023 15:33 — with GitHub Actions Inactive
@nils-wisiol
Copy link
Copy Markdown
Contributor Author

nils-wisiol commented Jun 17, 2023

@Cub0n is there a way to test your Github action without releasing a package? I'd like to get a feeling of this works before we publish.

@peterthomassen I had to create a new PR with (mostly) @Cub0n's code, but now that requires your review as per our repo rules. Can you take a look, please? :)

@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
@nils-wisiol nils-wisiol temporarily deployed to desec-test-account June 18, 2023 12:33 — with GitHub Actions Inactive
peterthomassen
peterthomassen reviewed Jun 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comments:

Building the Python package from scratch may not be reproducible due to package dependencies. We could consider always pulling the package of the same version from PyPi, but I'm not sure how that could be done.

Also, suggesting to squash before merging.

Comment thread .github/workflows/docker-build-publish.yml
run: |
docker buildx build . -f Dockerfile --platform ${{ matrix.cmd.platforms }} --push \
-t ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:${{ matrix.cmd.arch }}-${{ env.IMAGE_TAG }} \
-t ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:${{ matrix.cmd.arch }}-latest \
Copy link
Copy Markdown
Member

@peterthomassen peterthomassen Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we assuming that v* tags are added in strongly increasing order? If not, -latest should only be pushed on main branch.

Comment thread .github/workflows/docker-build-publish.yml
Comment on lines +77 to +81
docker manifest create ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:amd64-latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:arm32v6-latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:arm64v8-latest
docker manifest push ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:latest
Copy link
Copy Markdown
Member

@peterthomassen peterthomassen Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we assuming that v* tags are added in strongly increasing order? If not, -latest should only be pushed on main branch.

@Cub0n
Copy link
Copy Markdown

Cub0n commented Jul 29, 2023 •
edited
Loading

Hello @nils-wisiol,

@Cub0n is there a way to test your Github action without releasing a package? I'd like to get a feeling of this works before we publish.

no, unfortunately I was not able to test it without producing packages. Therefore I had/have a lot of during testing.
The whole process is divided into steps. After building with docker build, the package will be pushed with "--push" flag. Delete this flag, should not push it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterthomassen peterthomassen peterthomassen left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nils-wisiol @Cub0n @peterthomassen