Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Windows ARM64 POC #421

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Jan 23, 2021

Uses desktop/dugite-native#347

We're working on a native ARM64 version of Git for Windows 🚀 Since Dugite Native uses the MinGit packages provided by Git for Windows, this is a good opportunity for us to test if Dugite tests are passing.

This PR will likely remain WIP for a while until we're ready to publish the production builds of Git for Windows ARM64.

First test results - most are passing 🎉:

C:\repos\dugite>npm run test

> [email protected] test C:\repos\dugite
> npm run test:fast && npm run test:slow && npm run test:external


> [email protected] test:fast C:\repos\dugite
> cross-env LOCAL_GIT_DIRECTORY=./git/ jest --runInBand --silent --config ./jest.fast.config.js

 FAIL  test/fast/git-process-test.ts (12.832s)
  ● git-process › errors › can parse an error when pulling with merge with local changes

    expect(result).toHaveGitError(gitError)

    Expected
      "MergeWithLocalChanges"
    Received:
      null

      512 |       const result = await GitProcess.exec(['pull', 'origin', 'HEAD'], forkRepoPath)
      513 | 
    > 514 |       expect(result).toHaveGitError(GitError.MergeWithLocalChanges)
          |                      ^
      515 |     })
      516 | 
      517 |     it('can parse an error when pulling with rebase with local changes', async () => {

      at Object.<anonymous> (test/fast/git-process-test.ts:514:22)
      at fulfilled (test/fast/git-process-test.ts:7:24)

  ● git-process › errors › can parse an error when pulling with rebase with local changes

    expect(result).toHaveGitError(gitError)

    Expected
      "RebaseWithLocalChanges"
    Received:
      null

      549 |       const result = await GitProcess.exec(['pull', 'origin', 'HEAD'], forkRepoPath)
      550 | 
    > 551 |       expect(result).toHaveGitError(GitError.RebaseWithLocalChanges)
          |                      ^
      552 |     })
      553 | 
      554 |     it('can parse an error when there is a conflict while merging', async () => {

      at Object.<anonymous> (test/fast/git-process-test.ts:551:22)
      at fulfilled (test/fast/git-process-test.ts:7:24)

 FAIL  test/fast/errors-test.ts
  ● detects errors › RemoteAlreadyExists

    expect(result).toHaveGitError(gitError)

    Expected
      "RemoteAlreadyExists"
    Received:
      null

      15 |     )
      16 | 
    > 17 |     expect(result).toHaveGitError(GitError.RemoteAlreadyExists)
         |                    ^
      18 |   })
      19 |   it('TagAlreadyExists', async () => {
      20 |     const repoPath = await initialize('tag-already-exists-test-repo')

      at Object.<anonymous> (test/fast/errors-test.ts:17:20)
      at fulfilled (test/fast/errors-test.ts:7:24)

 FAIL  test/fast/config-test.ts
  ● config › sets http.sslBackend on Windows

    expect(received).toBe(expected) // Object.is equality

    Expected: "schannel"
    Received: ""

       6 |     if (process.platform === 'win32') {
       7 |       const result = await GitProcess.exec(['config', '--system', 'http.sslBackend'], os.homedir())
    >  8 |       expect(result.stdout.trim()).toBe('schannel')
         |                                    ^
       9 |     }
      10 |   })
      11 | 

      at Object.<anonymous> (test/fast/config-test.ts:8:36)
      at fulfilled (test/fast/config-test.ts:7:24)

 PASS  test/fast/lfs-test.ts
 PASS  test/fast/commit-test.ts
 PASS  test/fast/stdin-test.ts
 PASS  test/fast/status-test.ts
 PASS  test/fast/environment-test.ts

Test Suites: 3 failed, 5 passed, 8 total
Tests:       4 failed, 56 passed, 60 total
Snapshots:   0 total
Time:        17.173s, estimated 19s

GitHub Desktop tests with this PR:

Test Suites: 13 failed, 88 passed, 101 total
Tests:       45 failed, 6 skipped, 842 passed, 893 total
Snapshots:   4 passed, 4 total
Time:        431.078s

@dennisameling dennisameling changed the title [WIP] Windows arm64 POC [WIP] Windows ARM64 POC Jan 23, 2021
Copy link

@killmen136 killmen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants