Fix stale glossary adoption in selective retranslation#36
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
run_state.py planadopted every existingoutput_chunk*.mdwithout arun_state.jsonrecord asrecord_onlyby default. If a user had stale translated outputs and then introduced or edited a glossary before the first run-state record, glossary-sensitive chunks could be recorded as current and become permanentlyunchanged, silently preserving stale terminology in final book outputs. Alias-only glossary edits for already-selected terms were also ignored becauseterm_hashdid not include aliases.Root cause
The untracked-output path in
scripts/run_state.pydid not check whether the source chunk currently receives glossary terms before choosingrecord.scripts/glossary.py::term_hashonly hashed source/target/category, omitting prompt-affecting aliases.Fix
Validation
chunk0001planned asrecord_only, thenunchangedafter recording.chunk0001is intranslation_chunk_ids, glossary-freechunk0002remainsrecord_only.glossary_term_hash_changedforchunk0001.python3 -m unittest tests.test_run_state tests.test_glossary -v— 69 tests OK.python3 -m unittest discover -s tests -p 'test_*.py' -v— OK, 3 skipped.python3 -m compileall scripts tests— OK.