-
Notifications
You must be signed in to change notification settings - Fork 443
Supporting dotnet 10.0 preview version #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Supporting dotnet 10.0 preview version #1305
Conversation
Created issue for the failed test. |
…emoved by the automated version update PR
@@ -11,6 +11,7 @@ | |||
"latest", | |||
"lts", | |||
"none", | |||
"10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change it to 10.0-preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @eljog ,
The url https://builds.dotnet.microsoft.com/dotnet/Sdk/
used in dotnet feature to download the installation package, expects this version 10 to be passed on as 10.0
in the same way like other versions. The only way to label it as preview version would be possible if the exact version is provided like 10.0.100-preview.3.25201.16
.
Whereas in case of the dotnet devcontainer image, the base image is downloaded from mcr.microsoft.com/dotnet/
registry where the dotnet 10 versions are actuality labeled as 10.0-preview
for e.g. mcr.microsoft.com/dotnet/sdk:10.0-preview-trixie-slim
. Thats why it was possible there to label the version as 10.0-preview
for the image.
So in case of the dotnet feature if we want to change the version from 10.0
to 10.0-preview
, we will need a small customization in the feature to remove the preview part from the version parameter & use it in the script. Kindly let me know if we should do something like that for this PR.
With Regards,
Kaniska
Ref: Issue
Note: Also removed the obsolete azureedge CDN url's for downloading the dotnet installable as mentioned here .