Skip to content

Supporting dotnet 10.0 preview version #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Mar 21, 2025

Ref: Issue

Note: Also removed the obsolete azureedge CDN url's for downloading the dotnet installable as mentioned here .

@Kaniska244 Kaniska244 marked this pull request as ready for review March 24, 2025 15:14
@Kaniska244 Kaniska244 requested a review from a team as a code owner March 24, 2025 15:14
@Kaniska244
Copy link
Contributor Author

Created issue for the failed test.

@Kaniska244 Kaniska244 requested a review from ddoyle2017 April 25, 2025 06:38
@Mathiyarasy Mathiyarasy self-requested a review April 30, 2025 09:08
@@ -11,6 +11,7 @@
"latest",
"lts",
"none",
"10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change it to 10.0-preview?

Copy link
Contributor Author

@Kaniska244 Kaniska244 May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @eljog ,

The url https://builds.dotnet.microsoft.com/dotnet/Sdk/ used in dotnet feature to download the installation package, expects this version 10 to be passed on as 10.0 in the same way like other versions. The only way to label it as preview version would be possible if the exact version is provided like 10.0.100-preview.3.25201.16.

Whereas in case of the dotnet devcontainer image, the base image is downloaded from mcr.microsoft.com/dotnet/ registry where the dotnet 10 versions are actuality labeled as 10.0-preview for e.g. mcr.microsoft.com/dotnet/sdk:10.0-preview-trixie-slim. Thats why it was possible there to label the version as 10.0-preview for the image.

So in case of the dotnet feature if we want to change the version from 10.0 to 10.0-preview, we will need a small customization in the feature to remove the preview part from the version parameter & use it in the script. Kindly let me know if we should do something like that for this PR.

With Regards,
Kaniska

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants