Skip to content

fix: fix get_content() call for frappe v16 compatibility#44

Open
prateekkaramchandani wants to merge 1 commit intodevelopmentforpeople:developfrom
kaminds:develop
Open

fix: fix get_content() call for frappe v16 compatibility#44
prateekkaramchandani wants to merge 1 commit intodevelopmentforpeople:developfrom
kaminds:develop

Conversation

@prateekkaramchandani
Copy link
Copy Markdown

No description provided.

@niraj2477
Copy link
Copy Markdown

frappe does not check for read permission when-ever you do get_contents, but the overridden class does this.
This could break in production , we should remove downloadable check
@developmentforpeople

@niraj2477
Copy link
Copy Markdown

can we remove it in same pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants