-
Notifications
You must be signed in to change notification settings - Fork 10
Support icechunk #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbusecke
wants to merge
50
commits into
main
Choose a base branch
from
support-icechunk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support icechunk #101
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
441063e
Parametrize test parameters across test functions
5d760bc
Fix pre-commit failure
b87582d
Fix pyramid store detection in get_tile test
7890228
Update tests/test_app.py
jbusecke ad28eab
updated zarr; added zarr v3 test fixture; parametrize caching for tests
9161be4
Remove dask dependency
a018066
updated zarr fixtures+scripts; minor test changes+additions;add dask …
3e57c11
update tilejson expected responses
4d20b59
All tests passing with zarr v2 and v3
21f33d1
add icechunk fixture and generation script
e6d86ea
Remove debugs, fix most tests
d99859c
Merge branch 'main' into support-icechunk
jbusecke 791d618
Bump xarray + renable testing with cache
e1d90bf
Some more debugging of the tile test
98809ae
Fix errors by pinning rio-tiler
89b1755
Add git installation to Dockerfile
jbusecke ab81349
dummy whitespace commit
jbusecke de5e640
add pytest-xdist and regen uv.lock
900f2d5
Add notebook deps and example notebook
accce17
remove rio-tiler limit
vincentsarago 9d7c6a8
Add virtual icechunk tests + fixtures + responses
cbd9105
Merge branch 'support-icechunk' of https://github.com/developmentseed…
32a9c43
Switch back titiler deps to PR branch
9aed634
Test increasing timeout
32f3788
Add test notebook
3c255b6
add test notebooks
d246e9a
Merge remote-tracking branch 'upstream/main' into support-icechunk
5ebb636
updated uv.lock
0cfe71d
Move notebooks to hub testing
e3da262
updated notebooks
08e2aed
rewrite uv.lock
c9b731b
Move changes entirely to tt-multidim
b966716
Confirm deployment error with minio
5d95982
Before refactoring settings
59b7e29
Implement authorized chunk access via api settings
973d53f
Rebase on newest titiler release
26af58b
Catch empty auth_v_chunks dict before opening ic repo
06e1d20
Remove explicit passing of endpoint_url
a4852af
Update pre-commit config
d1bf556
Add chunk auth for waterinsight and podaac mur bucket
fe5e3e1
debug + add auth cunk access to app config
e1756d0
Add podaac auth
e9a1d48
remove test_reader for now.
f295ded
Add verbosity to pre-commit for gh action debugging
b74fa6a
More debug for pre commit
f2c935a
Exclude notebooks.
ee21baa
Add authorized chunk access for RASI data
jbusecke 0141b51
Remove system dependencies installation in Dockerfile
jbusecke ae5480c
Apply suggestions from code review
jbusecke 4d2735b
Clean up for review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,5 +105,7 @@ cdk.out/ | |
| node_modules | ||
| cdk.context.json | ||
| *.nc | ||
| .DS_Store | ||
|
|
||
| .test-deploy-env | ||
| .vscode/settings.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,8 +25,8 @@ classifiers = [ | |
| ] | ||
| dynamic = ["version"] | ||
| dependencies = [ | ||
| "titiler.core>=0.23.0,<0.24", | ||
| "titiler.xarray>=0.23.0,<0.24", | ||
| "titiler-core>=0.25.0,<0.26", | ||
| "titiler-xarray>=0.25.0,<0.26", | ||
| "aiohttp", | ||
| "aiobotocore>=2.24.0", | ||
| "boto3>=1.39.0", | ||
|
|
@@ -41,8 +41,9 @@ dependencies = [ | |
| "requests", | ||
| "rioxarray", | ||
| "s3fs", | ||
| "xarray", | ||
| "zarr>=2,<3", | ||
| "xarray>=2025.10.1", | ||
| "zarr>3.1.0", | ||
| "icechunk>=1.1.9", | ||
| ] | ||
|
|
||
| [project.optional-dependencies] | ||
|
|
@@ -56,6 +57,7 @@ lambda = [ | |
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "dask>=2025.9.1", | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this was beneficial for generating the test fixtures, but happy to remove it if you think that I should. |
||
| "fakeredis>=2.23.5", | ||
| "httpx", | ||
| "ipykernel>=6.30.1", | ||
|
|
@@ -65,15 +67,23 @@ dev = [ | |
| "pytest-asyncio>=0.24.0", | ||
| "pytest-cov>=5.0.0", | ||
| "pytest>=8.3.2", | ||
| "pytest-xdist", | ||
| "uvicorn>=0.34.0", | ||
| "yappi>=1.6.0", | ||
| "virtualizarr", | ||
| "obstore", | ||
| ] | ||
| deployment = [ | ||
| "aws-cdk-lib~=2.177.0", | ||
| "constructs>=10.4.2", | ||
| "pydantic-settings~=2.0", | ||
| "python-dotenv>=1.0.1", | ||
| ] | ||
| notebooks = [ | ||
| "folium", | ||
| "httpx", | ||
| "matplotlib", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/developmentseed/titiler-multidim" | ||
|
|
@@ -97,6 +107,8 @@ known_first_party = ["titiler"] | |
| default_section = "THIRDPARTY" | ||
|
|
||
| [tool.ruff] | ||
|
|
||
| [tool.ruff.lint] | ||
| select = [ | ||
| "D1", # pydocstyle errors | ||
| "E", # pycodestyle errors | ||
|
|
@@ -111,7 +123,7 @@ ignore = [ | |
| "B905", # ignore zip() without an explicit strict= parameter, only support with python >3.10 | ||
| ] | ||
|
|
||
| [tool.ruff.per-file-ignores] | ||
| [tool.ruff.lint.per-file-ignores] | ||
| "tests/test_app.py" = ["D1"] | ||
| "tests/fixtures/generate_test_zarr.py" = ["D1"] | ||
| "tests/fixtures/generate_test_reference.py" = ["D1"] | ||
|
|
@@ -126,8 +138,6 @@ explicit_package_bases = true | |
| requires = ["pdm-backend"] | ||
| build-backend = "pdm.backend" | ||
|
|
||
|
|
||
|
|
||
| [tool.pdm.version] | ||
| source = "file" | ||
| path = "src/titiler/multidim/__init__.py" | ||
|
|
@@ -142,3 +152,4 @@ excludes = ["tests/", "**/.mypy_cache", "**/.DS_Store"] | |
|
|
||
| [tool.pytest.ini_options] | ||
| addopts = "--cov=titiler.multidim --cov-report term-missing -s -vv" | ||
| pythonpath = ["src", "tests"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added pytest-xdist mostly for more performant tests locally. Does not do much on a 2 core gh runner.