Skip to content

Conversation

JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Aug 4, 2025

Description of Changes

updating go version 1.24

Related Issue(s)

devfile/api#1715

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • [o] Test automation

Does this repository's tests pass with your changes?

  • [o] Documentation

Does any documentation need to be updated with your changes?

  • [o] Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

@JslYoon JslYoon requested a review from a team as a code owner August 4, 2025 21:17
@openshift-ci openshift-ci bot requested review from elsony and johnmcollier August 4, 2025 21:18
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the failing CI

ERROR: failed to build: failed to solve: registry.access.redhat.com/ubi8/go-toolset:1.24: failed to resolve source metadata for registry.access.redhat.com/ubi8/go-toolset:1.24: registry.access.redhat.com/ubi8/go-toolset:1.24: not found

I wasn't able to pull this image locally either

@JslYoon JslYoon force-pushed the JslYoon/UpdateGo1.24 branch 2 times, most recently from 0c8611e to 6aac77b Compare August 7, 2025 15:18
Signed-off-by: Lucas Yoon <[email protected]>
@JslYoon JslYoon force-pushed the JslYoon/UpdateGo1.24 branch from 6aac77b to 061114d Compare August 8, 2025 14:05
@Jdubrick
Copy link
Contributor

/retest

@thepetk
Copy link
Contributor

thepetk commented Aug 11, 2025

Btw I feel this one should be merged soon as I see there's an issue after this commit of the registry-support and the CI is failing

https://github.com/devfile/registry/actions/runs/16881295727/job/47817561251?pr=627

@JslYoon JslYoon self-assigned this Aug 11, 2025
@JslYoon JslYoon force-pushed the JslYoon/UpdateGo1.24 branch from 524f8d3 to 061114d Compare August 11, 2025 18:48
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 11, 2025

@thepetk @Jdubrick do you know where ci/prow/v4.16-registry-test CI is set up? Looks like I need to update its go version from 1.23 to 1.24

@JslYoon JslYoon requested review from kadel, a team and msivasubramaniaan as code owners August 11, 2025 18:56
@michael-valdron
Copy link
Member

@thepetk @Jdubrick do you know where ci/prow/v4.16-registry-test CI is set up? Looks like I need to update its go version from 1.23 to 1.24

@JslYoon You'll need to update this line to golang-1.24 and open a PR under openshift/release to change the CI runtime.

FYI you will need to do the same for the other OpenShift CI checks (for devfile/registry-operator and devfile/integration-tests) as well.

@thepetk
Copy link
Contributor

thepetk commented Aug 12, 2025

@thepetk @Jdubrick do you know where ci/prow/v4.16-registry-test CI is set up? Looks like I need to update its go version from 1.23 to 1.24

@JslYoon You'll need to update this line to golang-1.24 and open a PR under openshift/release to change the CI runtime.

FYI you will need to do the same for the other OpenShift CI checks (for devfile/registry-operator and devfile/integration-tests) as well.

@JslYoon to add to michael's point you can take a look to a similar PR here: openshift/release#65672

Signed-off-by: Lucas Yoon <[email protected]>
@michael-valdron
Copy link
Member

/retest

@michael-valdron
Copy link
Member

/test all

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I would wait for @thepetk's approval as well.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JslYoon, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit b90f487 into main Aug 20, 2025
13 checks passed
@JslYoon JslYoon deleted the JslYoon/UpdateGo1.24 branch August 20, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants