-
Notifications
You must be signed in to change notification settings - Fork 93
updating go version to 1.24 #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the failing CI
ERROR: failed to build: failed to solve: registry.access.redhat.com/ubi8/go-toolset:1.24: failed to resolve source metadata for registry.access.redhat.com/ubi8/go-toolset:1.24: registry.access.redhat.com/ubi8/go-toolset:1.24: not found
I wasn't able to pull this image locally either
0c8611e
to
6aac77b
Compare
Signed-off-by: Lucas Yoon <[email protected]>
6aac77b
to
061114d
Compare
/retest |
Btw I feel this one should be merged soon as I see there's an issue after this commit of the https://github.com/devfile/registry/actions/runs/16881295727/job/47817561251?pr=627 |
524f8d3
to
061114d
Compare
@JslYoon You'll need to update this line to FYI you will need to do the same for the other OpenShift CI checks (for devfile/registry-operator and devfile/integration-tests) as well. |
@JslYoon to add to michael's point you can take a look to a similar PR here: openshift/release#65672 |
Signed-off-by: Lucas Yoon <[email protected]>
0fa4751
to
bdbfeef
Compare
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I would wait for @thepetk's approval as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JslYoon, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
updating go version 1.24
Related Issue(s)
devfile/api#1715
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)